[Cleanup] Merge Client::Attack and Bot::Attack into Mob::Attack #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
reviewed
Jan 18, 2023
|
I’ll look at this one later, running errands |
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Kinglykrab
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
reviewed
Jan 19, 2023
Akkadius
approved these changes
Jan 19, 2023
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the need to maintain multiple methods that do the same thing, Bots should be treated as clients for majority of scenarios encountered.
This also allows Bots to be affected by the Rule Combat:LevelToStopDamageCaps, previously they were ignoring it... which would have been an issue for anyone wanting to use DamageCaps with Bots
Mercs still use NPC::Attack method, as they derive their damage thru their base stats.