Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands] Remove #guildapprove, #guildcreate, and #guildlist Commands #2775

Merged
merged 1 commit into from Jan 22, 2023
Merged

[Commands] Remove #guildapprove, #guildcreate, and #guildlist Commands #2775

merged 1 commit into from Jan 22, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Removes #guildapprove, #guildcreate, and #guildlist.
  • Removes associated functions, classes, etc. that were only used in these commands.
  • These commands are unused and/or covered by the general #guild command.
  • Approvals don't really seem to be a thing anymore and the variable itself doesn't exist in stock PEQ database anyway.

@Kinglykrab
[Commands] Remove #guildapprove, #guildcreate, and #guildlist Commands
c0d67bd 
# Notes
- Removes `#guildapprove`, `#guildcreate`, and `#guildlist`.
- Removes associated functions, classes, etc. that were only used in these commands.
- These commands are unused and/or covered by the general `#guild` command.
- Approvals don't really seem to be a thing anymore and the variable itself doesn't exist in stock PEQ database anyway.
Aeadoin
Aeadoin approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@Aeadoin Aeadoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kinglykrab Kinglykrab merged commit d0edb93 into master Jan 22, 2023
@Kinglykrab Kinglykrab deleted the commands/remove_guild_commands branch January 22, 2023 17:56
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
@Kinglykrab @catapultam-habeo
[Commands] Remove #guildapprove, #guildcreate, and #guildlist Commands (
9cca966 
EQEmu#2775)

# Notes
- Removes `#guildapprove`, `#guildcreate`, and `#guildlist`.
- Removes associated functions, classes, etc. that were only used in these commands.
- These commands are unused and/or covered by the general `#guild` command.
- Approvals don't really seem to be a thing anymore and the variable itself doesn't exist in stock PEQ database anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joligario joligario joligario approved these changes

@Aeadoin Aeadoin Aeadoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kinglykrab @joligario @Aeadoin