Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Remove duplicate logic in GetActSpellHealing reducing HOT criticals #2786

Merged
merged 1 commit into from Jan 24, 2023
Merged

[Bug Fix] Remove duplicate logic in GetActSpellHealing reducing HOT criticals #2786

merged 1 commit into from Jan 24, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Removes duplicate critical chance roll in Mob::GetActSpellHealing.
  • Not sure if this was Live-like or an oversight, but it seems to drastically reduce the possibility of a HOT getting a critical.
  • A 1% chance becomes a 0.01% chance being we have to roll twice.

@Kinglykrab
[Bug Fix] Remove duplicate logic.
dc1391e 
# Notes
- Removes duplicate critical chance roll in `Mob::GetActSpellHealing`.
- Not sure if this was Live-like or an oversight, but it seems to drastically reduce the possibility of a HOT getting a critical.
- A 1% chance becomes a 0.01% chance being we have to roll twice.
@Akkadius Akkadius changed the title [Bug Fix] Remove duplicate logic. [Bug Fix] Remove duplicate logic in GetActSpellHealing reducing HOT criticals Jan 24, 2023
@Akkadius Akkadius merged commit 8c12f7b into master Jan 24, 2023
@Akkadius Akkadius deleted the bug_fix/hot_criticals branch January 24, 2023 18:39
@Akkadius Akkadius mentioned this pull request Jan 24, 2023
Merged
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
@Kinglykrab @catapultam-habeo
[Bug Fix] Remove duplicate logic in GetActSpellHealing reducing HOT c…
2ee47ad 
…riticals (EQEmu#2786)

# Notes
- Removes duplicate critical chance roll in `Mob::GetActSpellHealing`.
- Not sure if this was Live-like or an oversight, but it seems to drastically reduce the possibility of a HOT getting a critical.
- A 1% chance becomes a 0.01% chance being we have to roll twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Akkadius