[Quest API] Add EVENT_TASKACCEPTED to Player scope #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natedog2012
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Tested in perl/lua seems to work just fine! @Akkadius think this should be added to zone_controller as well?
Not sure that it needs to be in the zone controller |
Akkadius
reviewed
Feb 4, 2023
Kinglykrab
approved these changes
Feb 6, 2023
Merged
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
* Add EVENT_TASKACCEPTED to player scope * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously EVENT_TASKACCEPTED was only accesible in the NPC scope.
Change
This adds EVENT_TASKACCEPTED to the player scope for both Perl and Lua.
Tested on up-to-date binaries and works fine.