[Quest API] Add Recipe-based methods to Perl/Lua. #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Perl - Add `quest::get_recipe_component_item_ids(recipe_id)`. - Add `quest::get_recipe_container_item_ids(recipe_id)`. - Add `quest::get_recipe_fail_item_ids(recipe_id)`. - Add `quest::get_recipe_salvage_item_ids(recipe_id)`. - Add `quest::get_recipe_success_item_ids(recipe_id)`. - Add `quest::get_recipe_component_count(recipe_id, item_id)`. - Add `quest::get_recipe_fail_count(recipe_id, item_id)`. - Add `quest::get_recipe_salvage_count(recipe_id, item_id)`. - Add `quest::get_recipe_success_count(recipe_id, item_id)`. # Lua - Add `eq.get_recipe_component_item_ids(recipe_id)`. - Add `eq.get_recipe_container_item_ids(recipe_id)`. - Add `eq.get_recipe_fail_item_ids(recipe_id)`. - Add `eq.get_recipe_salvage_item_ids(recipe_id)`. - Add `eq.get_recipe_success_item_ids(recipe_id)`. - Add `eq.get_recipe_component_count(recipe_id, item_id)`. - Add `eq.get_recipe_fail_count(recipe_id, item_id)`. - Add `eq.get_recipe_salvage_count(recipe_id, item_id)`. - Add `eq.get_recipe_success_count(recipe_id, item_id)`. # Notes - Before these methods, you would have to use DBI from Perl or Lua in order to get the components and their counts, these methods allow easy access to these values via the scripting API. - These should be used sparingly as they're each an individual database hit and could go crazy in a hot path.
|
LGTM. I think Tradeskills are a great candidate to pull into memory without a huge lift |
Akkadius
approved these changes
Feb 7, 2023
Akkadius
reviewed
Feb 7, 2023
Akkadius
reviewed
Feb 7, 2023
Akkadius
reviewed
Feb 7, 2023
Akkadius
reviewed
Feb 7, 2023
|
Sounds good, I’ll do that. Makes sense to not have to resize it over and over each time something new is added. |
Merged
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
* [Quest API] Add Recipe-based methods to Perl/Lua. # Perl - Add `quest::get_recipe_component_item_ids(recipe_id)`. - Add `quest::get_recipe_container_item_ids(recipe_id)`. - Add `quest::get_recipe_fail_item_ids(recipe_id)`. - Add `quest::get_recipe_salvage_item_ids(recipe_id)`. - Add `quest::get_recipe_success_item_ids(recipe_id)`. - Add `quest::get_recipe_component_count(recipe_id, item_id)`. - Add `quest::get_recipe_fail_count(recipe_id, item_id)`. - Add `quest::get_recipe_salvage_count(recipe_id, item_id)`. - Add `quest::get_recipe_success_count(recipe_id, item_id)`. # Lua - Add `eq.get_recipe_component_item_ids(recipe_id)`. - Add `eq.get_recipe_container_item_ids(recipe_id)`. - Add `eq.get_recipe_fail_item_ids(recipe_id)`. - Add `eq.get_recipe_salvage_item_ids(recipe_id)`. - Add `eq.get_recipe_success_item_ids(recipe_id)`. - Add `eq.get_recipe_component_count(recipe_id, item_id)`. - Add `eq.get_recipe_fail_count(recipe_id, item_id)`. - Add `eq.get_recipe_salvage_count(recipe_id, item_id)`. - Add `eq.get_recipe_success_count(recipe_id, item_id)`. # Notes - Before these methods, you would have to use DBI from Perl or Lua in order to get the components and their counts, these methods allow easy access to these values via the scripting API. - These should be used sparingly as they're each an individual database hit and could go crazy in a hot path. * Update eq_constants.h * Update zonedb.h * Update tradeskills.cpp * Reserve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl
quest::get_recipe_component_item_ids(recipe_id).quest::get_recipe_container_item_ids(recipe_id).quest::get_recipe_fail_item_ids(recipe_id).quest::get_recipe_salvage_item_ids(recipe_id).quest::get_recipe_success_item_ids(recipe_id).quest::get_recipe_component_count(recipe_id, item_id).quest::get_recipe_fail_count(recipe_id, item_id).quest::get_recipe_salvage_count(recipe_id, item_id).quest::get_recipe_success_count(recipe_id, item_id).Lua
eq.get_recipe_component_item_ids(recipe_id).eq.get_recipe_container_item_ids(recipe_id).eq.get_recipe_fail_item_ids(recipe_id).eq.get_recipe_salvage_item_ids(recipe_id).eq.get_recipe_success_item_ids(recipe_id).eq.get_recipe_component_count(recipe_id, item_id).eq.get_recipe_fail_count(recipe_id, item_id).eq.get_recipe_salvage_count(recipe_id, item_id).eq.get_recipe_success_count(recipe_id, item_id).Notes