Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quest API] (Performance) Check event EVENT_COMBINE, EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, or EVENT_COMBINE_VALIDATE exist before export and execute #2896

Merged
merged 3 commits into from Feb 13, 2023
Merged

[Quest API] (Performance) Check event EVENT_COMBINE, EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, or EVENT_COMBINE_VALIDATE exist before export and execute #2896

merged 3 commits into from Feb 13, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Optionally parse these events instead of always doing so.

@Kinglykrab Kinglykrab changed the title [Quest API] Optionally parse EVENT_COMBINE_SUCCESS and EVENT_COMBINE_FAILURE [Quest API] Optionally parse EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, and EVENT_COMBINE_VALIDATE Feb 12, 2023
@Kinglykrab Kinglykrab changed the title [Quest API] Optionally parse EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, and EVENT_COMBINE_VALIDATE [Quest API] Optionally parse EVENT_COMBINE, EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, and EVENT_COMBINE_VALIDATE Feb 12, 2023
@Kinglykrab Kinglykrab changed the title [Quest API] Optionally parse EVENT_COMBINE, EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, and EVENT_COMBINE_VALIDATE [Quest API] (Performance) Check event EVENT_COMBINE, EVENT_COMBINE_SUCCESS, EVENT_COMBINE_FAILURE, or EVENT_COMBINE_VALIDATE exist before export and execute Feb 13, 2023
@Akkadius Akkadius force-pushed the quest_api/combine_events_optional branch from f836a8c to c8fc66f Compare February 13, 2023 05:28
@Akkadius Akkadius merged commit 3d6b0e5 into master Feb 13, 2023
@Akkadius Akkadius deleted the quest_api/combine_events_optional branch February 13, 2023 05:28
@Akkadius Akkadius mentioned this pull request Feb 16, 2023
Merged
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
@Kinglykrab @catapultam-habeo
[Quest API] (Performance) Check event EVENT_COMBINE, EVENT_COMBINE_SU…
2c596b5 
…CCESS, EVENT_COMBINE_FAILURE, or EVENT_COMBINE_VALIDATE exist before export and execute (EQEmu#2896)

* [Quest API] Optionally parse EVENT_COMBINE_SUCCESS and EVENT_COMBINE_FAILURE

- Optionally parse these events instead of always doing so.

* Update tradeskills.cpp

* Update tradeskills.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Akkadius