Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest API] (Performance) Check spell or cast events exist before export and execute #2897

Merged
merged 3 commits into from Feb 13, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Optionally parses EVENT_CAST, EVENT_CAST_BEGIN, EVENT_CAST_ON, EVENT_SPELL_EFFECT_NPC, EVENT_SPELL_EFFECT_CLIENT, EVENT_SPELL_EFFECT_BOT, EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT, EVENT_SPELL_EFFECT_BUFF_TIC_NPC, EVENT_SPELL_EFFECT_BUFF_TIC_BOT, EVENT_SPELL_FADE, and EVENT_SPELL_EFFECT_TRANSLOCATE_COMPLETE.

# Notes
- Optionally parses `EVENT_CAST`, `EVENT_CAST_BEGIN`, `EVENT_CAST_ON`, `EVENT_SPELL_EFFECT_NPC`, `EVENT_SPELL_EFFECT_CLIENT`, `EVENT_SPELL_EFFECT_BOT`, `EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT`, `EVENT_SPELL_EFFECT_BUFF_TIC_NPC`, `EVENT_SPELL_EFFECT_BUFF_TIC_BOT`, `EVENT_SPELL_FADE`, and `EVENT_SPELL_EFFECT_TRANSLOCATE_COMPLETE`.
@Kinglykrab Kinglykrab changed the title [Quest API] Optionally parse spell/cast events [Quest API] (Performance) Check spell or cast events exist before export and execute Feb 13, 2023
zone/spell_effects.cpp Outdated Show resolved Hide resolved
zone/spells.cpp Outdated Show resolved Hide resolved
zone/spells.cpp Outdated Show resolved Hide resolved
@Akkadius Akkadius merged commit 9f61985 into master Feb 13, 2023
@Akkadius Akkadius deleted the quest_api/spell_cast_events_optional branch February 13, 2023 05:26
Akkadius added a commit that referenced this pull request Feb 14, 2023
…d by #2897 (#2928)

* [Hotfix] Fix EVENT_SPELL_EFFECT_TRANSLOCATE_COMPLETE regression caused by  #2897

* Update client_packet.cpp
@Akkadius Akkadius mentioned this pull request Feb 16, 2023
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
…ort and execute (EQEmu#2897)

* [Quest API] Optionally parse spell/cast events

# Notes
- Optionally parses `EVENT_CAST`, `EVENT_CAST_BEGIN`, `EVENT_CAST_ON`, `EVENT_SPELL_EFFECT_NPC`, `EVENT_SPELL_EFFECT_CLIENT`, `EVENT_SPELL_EFFECT_BOT`, `EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT`, `EVENT_SPELL_EFFECT_BUFF_TIC_NPC`, `EVENT_SPELL_EFFECT_BUFF_TIC_BOT`, `EVENT_SPELL_FADE`, and `EVENT_SPELL_EFFECT_TRANSLOCATE_COMPLETE`.

* Cleanup

* PR comment fixes

---------

Co-authored-by: Akkadius <akkadius1@gmail.com>
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
…d by EQEmu#2897 (EQEmu#2928)

* [Hotfix] Fix EVENT_SPELL_EFFECT_TRANSLOCATE_COMPLETE regression caused by  EQEmu#2897

* Update client_packet.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants