[Rules] Add Multiplier for Heroic Stats. #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#mystats is now showing correctly for Mana and regen values provided by heroic stats. |
Kinglykrab
approved these changes
Mar 4, 2023
Akkadius
approved these changes
Mar 4, 2023
Merged
nytmyr
pushed a commit
to nytmyr/Server
that referenced
this pull request
Dec 1, 2023
* initial work * [Rules] Add Multiplier for Heroic Stats. * Add bots * update SendStatsWindow * fix SendStatsWindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Server Operators to increase/Reduce effect of Heroic Stats by setting a multiplier for each stat.
Have found most locations where heroic stats are leveraged, I've chosen not to allow the multipliers to work on Evasion based skills (as it could easily cause an operator to shoot their own foot)
Still need to ensure all fields from #mystats command are updating correctly. Max mana wasn't when I increased multiplier on Heroic Wisdom, but it was showing the increase correctly in the client inventory.