Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Cursor Coin Upon Death #3020

Merged
merged 2 commits into from Mar 4, 2023
Merged

Conversation

cybernine186
Copy link
Contributor

Upon death if a character has coin on cursor it will not transfer to the corpse, rather stay on cursor after death. This fix will remove all coin on cursor and save it to the corpse.

Copy link
Contributor

@Kinglykrab Kinglykrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Live-like? If so, looks good to me.

@Aeadoin
Copy link
Contributor

Aeadoin commented Mar 4, 2023

Is this Live-like? If so, looks good to me.

Agreed, this i great as we don't want to be leaving things dangling on cursors if we can help it!
if we can get someone to confirm on Live this would be great... or even if they just transfer the coin to inventory that would be good too.

@Kinglykrab
Copy link
Contributor

Tested on Live, money stays on cursor on death. Would make more sense to make this rule-based than have it be the default functionality, as it's inconsistent with Live. Default false for the rule to be disabled by default.

@Kinglykrab
Copy link
Contributor

Added a rule toggle for this.

Copy link
Contributor

@Aeadoin Aeadoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kinglykrab Kinglykrab merged commit be567af into EQEmu:master Mar 4, 2023
@Aeadoin Aeadoin mentioned this pull request Mar 24, 2023
nytmyr pushed a commit to nytmyr/Server that referenced this pull request Dec 1, 2023
* Update corpse.cpp

* Add rule toggle.

---------

Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants