New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Cleanup uses of Strings::ToInt to match correct type. #3054

Merged

Aeadoin merged 3 commits into EQEmu:master from Aeadoin:validatestringsto

Mar 22, 2023

Contributor

Aeadoin commented Mar 11, 2023

Change unsigned ints to use Strings::ToUnsignedInt, and bools to use Strings::ToBool wherever I could find a mismatch in type


          [Cleanup] Cleanup uses of Strings::ToInt to match correct type.

928eda2

Kinglykrab approved these changes

View reviewed changes

Member

Akkadius commented Mar 14, 2023

I'll look at this soon

Akkadius reviewed

View reviewed changes

common/strings.h Show resolved Hide resolved

Akkadius reviewed

View reviewed changes

loginserver/account_management.cpp Outdated Show resolved Hide resolved

Akkadius reviewed

View reviewed changes

common/guild_base.cpp Outdated Show resolved Hide resolved

Akkadius reviewed

View reviewed changes

common/guild_base.cpp Outdated Show resolved Hide resolved

Akkadius reviewed

View reviewed changes

Member

Akkadius left a comment

Looks generally good, have you tested thoroughly?


          cleanup

704e938

Contributor Author

Aeadoin commented Mar 20, 2023

I've tested a bit so far, but would feel more comfortable with a bit more testing. maybe @Kinglykrab would be willing to do some testing as well.

Contributor Author

Aeadoin commented Mar 21, 2023

I've tested a bit so far, but would feel more comfortable with a bit more testing. maybe @Kinglykrab would be willing to do some testing as well.

I did a bunch more testing this morning on this:

Killing mobs when in a Group/Raid
Dying
Looting Items
Forming a Guild, promoting/demoting/removal

Anything that this PR touched basically.


          Merge branch 'EQEmu:master' into validatestringsto

93a708b

Contributor Author

Aeadoin commented Mar 21, 2023

Going to Merge Master into this and do more testing. just to be safe

Contributor Author

Aeadoin commented Mar 22, 2023

Going to Merge Master into this and do more testing. just to be safe

This seems solid with my testing.

Aeadoin merged commit 2e2c4d6 into EQEmu:master

Aeadoin deleted the validatestringsto branch

March 22, 2023 16:22

nytmyr pushed a commit to nytmyr/Server that referenced this pull request


          [Cleanup] Cleanup uses of Strings::ToInt to match correct type. (EQEm…

35b2966

…u#3054)

* [Cleanup] Cleanup uses of Strings::ToInt to match correct type.

* cleanup

Aeadoin mentioned this pull request

[Release] 22.7.0 #3143

Merged

nytmyr pushed a commit to nytmyr/Server that referenced this pull request


          [Cleanup] Cleanup uses of Strings::ToInt to match correct type. (EQEm…

1ec9c99

…u#3054)

* [Cleanup] Cleanup uses of Strings::ToInt to match correct type.

* cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment