Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Cleaning up Raid.cpp #3125

Merged
merged 8 commits into from Mar 20, 2023
Merged

[Cleanup] Cleaning up Raid.cpp #3125

merged 8 commits into from Mar 20, 2023

Conversation

Aeadoin
Copy link
Contributor

@Aeadoin Aeadoin commented Mar 18, 2023

I've started to cleanup raid.cpp, I also resolved a couple potential crashes where we could have went out of bounds when returning GetPlayerIndex() that @Akkadius pointed out under #2782

Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/bot.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/bot_raid.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/lua_entity.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/npc.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/perl_mob.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.h Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed Mar 19, 2023
View reviewed changes
zone/raids.cpp Outdated Show resolved Hide resolved
@Aeadoin Aeadoin requested a review from Kinglykrab March 19, 2023 22:13
@Aeadoin Aeadoin mentioned this pull request Mar 19, 2023
Closed
@Aeadoin Aeadoin merged commit d6b954a into EQEmu:master Mar 20, 2023
@Aeadoin Aeadoin deleted the raidfixes branch March 20, 2023 15:39
@Aeadoin Aeadoin mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kinglykrab Kinglykrab Kinglykrab approved these changes

@Akkadius Akkadius Awaiting requested review from Akkadius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aeadoin @Kinglykrab