[Backups] Fix database dump error reporting #3175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes an issue where database dumps would not bubble
stderr
from the underlying process execution. Currently this pipesstderr
tostdout
so we don't miss errors, this could be later improved to hold a response object containingstatus
stderr
andstdout
This is to prevent server operators from experiencing any sort of data loss if they are missing a table that the database backup is trying to request explicitly. If a table is missing,
mysqldump
will normally stop.We could ignore this but this really is something that should be addressed immediately otherwise it could cause worse pain to ignore.
mysqldump
error is detected, the world process is exited forcefullyFile::GetContents(file_name)