Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove extraneous loottable_id setting in WakeTheDead in aa.cpp #3215

Merged
merged 1 commit into from Apr 3, 2023
Merged

[Cleanup] Remove extraneous loottable_id setting in WakeTheDead in aa.cpp #3215

merged 1 commit into from Apr 3, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • We already set made_npc->loottable_id to 0 above.

@Kinglykrab
[Cleanup] Remove extraneous loottable_id setting in WakeTheDead in aa…
5dc6115 
….cpp

# Notes
- We already set `made_npc->loottable_id` to `0` above.
Aeadoin
Aeadoin approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@Aeadoin Aeadoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually look at switching anything like this to use in-class member initializers.

@Aeadoin Aeadoin merged commit 32be049 into master Apr 3, 2023
2 checks passed
@Aeadoin Aeadoin deleted the cleanup/wakethedead_loottable_id branch April 3, 2023 20:59
@Aeadoin Aeadoin mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aeadoin Aeadoin Aeadoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Aeadoin