Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Add initiator/owner checks to various methods in questmgr.cpp #3306

Merged
merged 5 commits into from Apr 23, 2023

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Apr 23, 2023

Notes

  • Add initiator check to quest::permaclass().
  • Add initiator check to quest::permarace().
  • Add initiator check to quest::permagender().
  • Add initiator check to quest::scribespells().
  • Add initiator check to quest::traindiscs().
  • Add initiator check to quest::unscribespells().
  • Add initiator check to quest::untraindiscs().
  • Cleanup initiator check in quest::pvp().
  • Cleanup initiator check in quest::movepc().
  • Cleanup initiator check in quest::gmmove().
  • Cleanup initiator check in quest::movegrp().
  • Add owner check to quest::doanim().
  • Cleanup initiator check in quest::addskill().
  • Cleanup initiator check in quest::setlanguage().
  • Cleanup initiator check in quest::setskill().
  • Cleanup initiator check in quest::has_zone_flag().
  • Cleanup initiator check in quest::set_zone_flag().
  • Cleanup initiator check in quest::clear_zone_flag().
  • Add owner check to quest::sethp().
  • Add owner check to quest::npcrace().
  • Add owner check to quest::npcgender().
  • Add owner check to quest::npcsize().
  • Add owner check to quest::npctexture().
  • Add initiator check to quest::playerrace().
  • Add initiator check to quest::playergender().
  • Add initiator check to quest::playersize().
  • Add initiator check to quest::playertexture().
  • Add initiator check to quest::playerfeature().
  • Add owner check to quest::npcfeature().
  • Cleanup initiator check in quest::popup().
  • Add initiator check to quest::getlevel().
  • Add initiator check to quest::collectitems_processSlot().
  • Add initiator check to quest::countitem().
  • Add initiator check to quest::removeitem().
  • Add owner check to quest::FactionValue().
  • Add initiator check to quest::enabletitle().
  • Add initiator check to quest::checktitle().
  • Add initiator check to quest::removetitle().
  • Add owner check to quest::wearchange().
  • Add owner check to quest::voicetell().
  • Cleanup nullptr checks in quest::SendMail().

# Notes
- Add `initiator` check to `quest::permaclass()`.
- Add `initiator` check to `quest::permarace()`.
- Add `initiator` check to `quest::permagender()`.
- Add `initiator` check to `quest::scribespells()`.
- Add `initiator` check to `quest::traindiscs()`.
- Add `initiator` check to `quest::unscribespells()`.
- Add `initiator` check to `quest::untraindiscs()`.
- Cleanup `initiator` check in `quest::pvp()`.
- Cleanup `initiator` check in `quest::movepc()`.
- Cleanup `initiator` check in `quest::gmmove()`.
- Cleanup `initiator` check in `quest::movegrp()`.
- Add `owner` check to `quest::doanim()`.
- Cleanup `initiator` check in `quest::addskill()`.
- Cleanup `initiator` check in `quest::setlanguage()`.
- Cleanup `initiator` check in `quest::setskill()`.
@Aeadoin Aeadoin merged commit 576f99f into master Apr 23, 2023
2 checks passed
@Aeadoin Aeadoin deleted the cleanup/initiator_owner_checks branch April 23, 2023 19:08
@Akkadius Akkadius mentioned this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants