Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Character bind is now bulk saved #3338

Merged
merged 2 commits into from May 9, 2023

Conversation

Akkadius
Copy link
Member

@Akkadius Akkadius commented May 8, 2023

This PR combines individual character_bind queries during Save() into one

This also fixes a long time bug where character heading is not being properly saved in bind

  Zone |   Query    | QueryDatabase DELETE FROM character_bind WHERE id = 1 -- (5 rows affected) (0.008630s)-- [poair] (The Plane of Air) inst_id [0]
  Zone |   Query    | QueryDatabase INSERT INTO character_bind (id, slot, zone_id, instance_id, x, y, z, heading)  VALUES (1,0,189,0,18.000000,-147.000000,20.000000,192.000000),(1,1,29,0,-456.000000,560.000000,-26.000000,192.000000),(1,2,29,0,-456.000000,560.000000,-26.000000,192.000000),(1,3,29,0,-456.000000,560.000000,-26.000000,192.000000),(1,4,29,0,-456.000000,560.000000,-26.000000,192.000000) -- (5 rows affected) (0.000310s)-- [poair] (The Plane of Air) inst_id [0]

@Akkadius Akkadius merged commit 612029d into master May 9, 2023
2 checks passed
@Akkadius Akkadius deleted the akkadius/character-bind-bulk-save branch May 9, 2023 18:22
@Akkadius Akkadius mentioned this pull request May 30, 2023
nytmyr pushed a commit to nytmyr/Server that referenced this pull request Dec 1, 2023
* [Performance] Character bind is now bulk saved

* Fix bind heading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants