Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telnet] Add cross zone/world wide cast and move functionality to Telnet #3409

Merged
merged 5 commits into from Jun 17, 2023
Merged

[Telnet] Add cross zone/world wide cast and move functionality to Telnet #3409

merged 5 commits into from Jun 17, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Add czcast, czmove, wwcast, and wwmove to Telnet functionality.
  • Allows operators to cast spells across zone/world-wide and move players across zone/world-wide from telnet.

@Kinglykrab
[Telnet] Add cross zone/world wide cast and move functionality to Telnet
9fcf5f9 
# Notes
- Add `czcast`, `czmove`, `wwcast`, and `wwmove` to Telnet functionality.
- Allows operators to cast spells across zone/world-wide and move players across zone/world-wide from telnet.
@Kinglykrab
Update console.cpp
e439ca3
@Kinglykrab
Update console.cpp
d596936
Akkadius
Akkadius reviewed Jun 17, 2023
View reviewed changes
world/console.cpp Outdated Show resolved Hide resolved
Akkadius
Akkadius reviewed Jun 17, 2023
View reviewed changes
world/console.cpp Outdated Show resolved Hide resolved
Akkadius
Akkadius reviewed Jun 17, 2023
View reviewed changes
world/console.cpp Outdated Show resolved Hide resolved
Akkadius
Akkadius reviewed Jun 17, 2023
View reviewed changes
world/console.cpp Outdated Show resolved Hide resolved
Akkadius
Akkadius approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. In general we could use more validation on inputs to be on the safe side especially with world crashes being higher impact in production.

@Kinglykrab
Copy link
Contributor Author

Added validation.

Akkadius
Akkadius reviewed Jun 17, 2023
View reviewed changes
world/console.cpp Outdated Show resolved Hide resolved
@Akkadius Akkadius merged commit 57243c6 into master Jun 17, 2023
2 checks passed
@Akkadius Akkadius deleted the telnet/czcast_czmove_wwcast_wwmove branch June 17, 2023 22:50
@Akkadius Akkadius mentioned this pull request Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Akkadius