[Bug Fix] Fix bots/Mercenaries being removed from hatelist #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Notes - #3595 caused bots, bot pets, and mercenaries to be removed from hate list because we were only checking for `IsClient()` not `IsOfClientBotMerc()`. - Resolves an issue mentioned [here](https://discord.com/channels/212663220849213441/1177288302383079534) where NPCs would run past bots/mercenaries to attack the owner.
joligario
approved these changes
Nov 23, 2023
Kinglykrab
added a commit
that referenced
this pull request
Nov 23, 2023
### Admin * Update date in changelog ([#3698](#3698)) @joligario 2023-11-19 ### Code * Fix typo in #giveitem ([#3704](#3704)) @Kinglykrab 2023-11-22 ### Fixes * Add "IgnoreLevelBasedHasteCaps" rule to GetHaste() ([#3705](#3705)) @jcr4990 2023-11-23 * Fix bots/Mercenaries being removed from hatelist ([#3708](#3708)) @Kinglykrab 2023-11-23 * Fix some spell types failing IsValidSpellRange check ([#3707](#3707)) @nytmyr 2023-11-23 ### Loginserver * Update ticket login table structure ([#3703](#3703)) @KimLS 2023-11-22
Merged
Kinglykrab
added a commit
that referenced
this pull request
Nov 24, 2023
### Admin * Update date in changelog ([#3698](#3698)) @joligario 2023-11-19 ### Code * Fix typo in #giveitem ([#3704](#3704)) @Kinglykrab 2023-11-22 ### Fixes * Add "IgnoreLevelBasedHasteCaps" rule to GetHaste() ([#3705](#3705)) @jcr4990 2023-11-23 * Fix bots/Mercenaries being removed from hatelist ([#3708](#3708)) @Kinglykrab 2023-11-23 * Fix some spell types failing IsValidSpellRange check ([#3707](#3707)) @nytmyr 2023-11-23 ### Loginserver * Update ticket login table structure ([#3703](#3703)) @KimLS 2023-11-22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
IsClient()notIsOfClientBotMerc().