Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove hard-coded Status Checks #3727

Merged
merged 2 commits into from Dec 3, 2023
Merged

[Cleanup] Remove hard-coded Status Checks #3727

merged 2 commits into from Dec 3, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Removed the hard-coded GM status checks since if you have access to the command we can now limit access to subcommands if necessary.

@Kinglykrab
[Cleanup] Remove hard-coded Status Checks
d04fe26 
# Notes
- Removed the hard-coded GM status checks since if you have access to the command we can now limit access to subcommands if necessary.
@Kinglykrab
Update client_packet.cpp
ddca964
@Kinglykrab Kinglykrab merged commit e719aa4 into master Dec 3, 2023
2 checks passed
@Kinglykrab Kinglykrab deleted the cleanup/hardcoded_status branch December 3, 2023 16:44
joligario added a commit that referenced this pull request Dec 11, 2023
@joligario
[Release] 22.35.0
6103090 
### Bots

* Add BotHealOnLevel to fully heal/mana on level. ([#3745](#3745)) @nytmyr 2023-12-08
* Fix bots learning spells on level ([#3744](#3744)) @nytmyr 2023-12-08

### Bug

* Fix blocked spells regression from #3638 ([#3753](#3753)) @joligario 2023-12-11
* PR 3638 Missed the blocked spells repository updates ([#3748](#3748)) @fryguy503 2023-12-08

### CMake

* Update minimum version of CMake ([#3743](#3743)) @joligario 2023-12-08

### Code

* Remove hard-coded Status Checks ([#3727](#3727)) @Kinglykrab 2023-12-03

### Commands

* #guild set CharName 0 did not remove char from guild. ([#3717](#3717)) @noudess 2023-11-25
* #petname changes PC to Nobody if selected. ([#3720](#3720)) @noudess 2023-11-26
* Add #show aas Command ([#3710](#3710)) @Kinglykrab 2023-11-26
* Add #task complete Command ([#3711](#3711)) @Kinglykrab 2023-11-26
* Cleanup #acceptrules Command ([#3716](#3716)) @Kinglykrab 2023-11-26
* Cleanup #disarmtrap Command ([#3713](#3713)) @Kinglykrab 2023-11-26
* Cleanup #list Command ([#3714](#3714)) @Kinglykrab 2023-11-26
* Cleanup #movement Command ([#3715](#3715)) @Kinglykrab 2023-11-26
* Cleanup #object Command ([#3722](#3722)) @Kinglykrab 2023-12-03
* Cleanup #zonebootup and #zoneshutdown Commands ([#3729](#3729)) @Kinglykrab 2023-12-03
* Fix formatting of #wpinfo output. ([#3728](#3728)) @noudess 2023-12-01

### Database

* Add primary key to keyring table ([#3746](#3746)) @Kinglykrab 2023-12-08
* Consolidate Starting Items Table ([#3723](#3723)) @Kinglykrab 2023-11-30
* Extra whitespace in #3723 ([#3730](#3730)) @joligario 2023-12-02
* Minor adjustment to #3726 ([#3732](#3732)) @joligario 2023-12-03
* Modify `updated` column in `items` table with proper default. ([#3726](#3726)) @joligario 2023-12-02
* Pull Spell Group Cache from Content DB ([#3749](#3749)) @fryguy503 2023-12-08

### Faction

* Alliance line is only allowed 1 faction change at a time. ([#3718](#3718)) @noudess 2023-11-26

### Fixes

* Changing Group Leader Invalidated GetLeaderName() ([#3712](#3712)) @Kinglykrab 2023-11-26
* Fix 9245 SQL ([#3740](#3740)) @Kinglykrab 2023-12-05
* Fix Swarm Pets Requiring NPC Aggros Flag ([#3738](#3738)) @Kinglykrab 2023-12-05
* Guild Message Limits ([#3724](#3724)) @neckkola 2023-11-29

### Quest API

* Add EVENT_AA_GAIN to AddAAPoints() ([#3733](#3733)) @Kinglykrab 2023-12-03
* Add GMMove Overloads to Perl/Lua ([#3719](#3719)) @Kinglykrab 2023-11-25

### Scripts

* Import items into `items_new` table instead of writing directly to the existing `items` table. ([#3725](#3725)) @joligario 2023-11-30
* Revert database engine change from #3702. ([#3736](#3736)) @joligario 2023-12-03
* Update 13th Floor Import Tool ([#3702](#3702)) @joligario 2023-11-26
@joligario joligario mentioned this pull request Dec 11, 2023
Merged
Kinglykrab pushed a commit that referenced this pull request Dec 11, 2023
@joligario
[Release] 22.35.0 (#3754)
871f320 
### Bots

* Add BotHealOnLevel to fully heal/mana on level. ([#3745](#3745)) @nytmyr 2023-12-08
* Fix bots learning spells on level ([#3744](#3744)) @nytmyr 2023-12-08

### Bug

* Fix blocked spells regression from #3638 ([#3753](#3753)) @joligario 2023-12-11
* PR 3638 Missed the blocked spells repository updates ([#3748](#3748)) @fryguy503 2023-12-08

### CMake

* Update minimum version of CMake ([#3743](#3743)) @joligario 2023-12-08

### Code

* Remove hard-coded Status Checks ([#3727](#3727)) @Kinglykrab 2023-12-03

### Commands

* #guild set CharName 0 did not remove char from guild. ([#3717](#3717)) @noudess 2023-11-25
* #petname changes PC to Nobody if selected. ([#3720](#3720)) @noudess 2023-11-26
* Add #show aas Command ([#3710](#3710)) @Kinglykrab 2023-11-26
* Add #task complete Command ([#3711](#3711)) @Kinglykrab 2023-11-26
* Cleanup #acceptrules Command ([#3716](#3716)) @Kinglykrab 2023-11-26
* Cleanup #disarmtrap Command ([#3713](#3713)) @Kinglykrab 2023-11-26
* Cleanup #list Command ([#3714](#3714)) @Kinglykrab 2023-11-26
* Cleanup #movement Command ([#3715](#3715)) @Kinglykrab 2023-11-26
* Cleanup #object Command ([#3722](#3722)) @Kinglykrab 2023-12-03
* Cleanup #zonebootup and #zoneshutdown Commands ([#3729](#3729)) @Kinglykrab 2023-12-03
* Fix formatting of #wpinfo output. ([#3728](#3728)) @noudess 2023-12-01

### Database

* Add primary key to keyring table ([#3746](#3746)) @Kinglykrab 2023-12-08
* Consolidate Starting Items Table ([#3723](#3723)) @Kinglykrab 2023-11-30
* Extra whitespace in #3723 ([#3730](#3730)) @joligario 2023-12-02
* Minor adjustment to #3726 ([#3732](#3732)) @joligario 2023-12-03
* Modify `updated` column in `items` table with proper default. ([#3726](#3726)) @joligario 2023-12-02
* Pull Spell Group Cache from Content DB ([#3749](#3749)) @fryguy503 2023-12-08

### Faction

* Alliance line is only allowed 1 faction change at a time. ([#3718](#3718)) @noudess 2023-11-26

### Fixes

* Changing Group Leader Invalidated GetLeaderName() ([#3712](#3712)) @Kinglykrab 2023-11-26
* Fix 9245 SQL ([#3740](#3740)) @Kinglykrab 2023-12-05
* Fix Swarm Pets Requiring NPC Aggros Flag ([#3738](#3738)) @Kinglykrab 2023-12-05
* Guild Message Limits ([#3724](#3724)) @neckkola 2023-11-29

### Quest API

* Add EVENT_AA_GAIN to AddAAPoints() ([#3733](#3733)) @Kinglykrab 2023-12-03
* Add GMMove Overloads to Perl/Lua ([#3719](#3719)) @Kinglykrab 2023-11-25

### Scripts

* Import items into `items_new` table instead of writing directly to the existing `items` table. ([#3725](#3725)) @joligario 2023-11-30
* Revert database engine change from #3702. ([#3736](#3736)) @joligario 2023-12-03
* Update 13th Floor Import Tool ([#3702](#3702)) @joligario 2023-11-26
Akkadius added a commit that referenced this pull request Dec 16, 2023
@Akkadius
[Corpse] Fix /corpse command regression from #3727
757e9e6
@Akkadius Akkadius mentioned this pull request Dec 16, 2023
Merged
Akkadius added a commit that referenced this pull request Dec 16, 2023
@Akkadius
[Corpse] Fix /corpse command regression from #3727 (#3770)
e504482
@Akkadius Akkadius mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joligario joligario joligario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @joligario