[Quest API] Add EVENT_ALT_CURRENCY_GAIN and EVENT_ALT_CURRENCY_LOSS to Perl/Lua #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think LOSS implies losing, where SPENT might be a better description? Just a recommendation, may be just pedantic, but perhaps EARNED/SPENT might be better? Never used ALT Currency before. Can you also trade them? |
Just following the naming convention we used for AA gain/loss and Currency gain/loss. You can't trade the alternate currencies directly, only if you reclaim them as an item. |
Kinglykrab
changed the title
Akkadius
approved these changes
Dec 17, 2023
- Add `EVENT_ALT_CURRENCY_GAIN`. - Add `EVENT_ALT_CURRENCY_LOSS`. - Export `$currency_id`, `$amount`, and `$total. - Add `event_alt_currency_gain`. - Add `event_alt_currency_loss`. - Export `e.currency_id`, `e.amount`, and `e.total. - Convert `int8 method` to `bool is_scripted` in `Client::AddAlternateCurrencyValue`. - Properly utilize `is_scripted` parameter in `perl_client.cpp`. - Allows operators to perform events on alternate currency gains/losses.
Akkadius
force-pushed
the
quest_api/event_alt_currency_gain_loss
branch
from
211d8d1
to
8ba0520
Compare
Akkadius
approved these changes
Dec 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl
EVENT_ALT_CURRENCY_GAIN.EVENT_ALT_CURRENCY_LOSS.$currency_id,$amount, and$total.Lua
event_alt_currency_gain.event_alt_currency_loss.e.currency_id,e.amount, ande.total.Notes
int8 methodtobool is_scriptedinClient::AddAlternateCurrencyValue.is_scriptedparameter inperl_client.cpp.