New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Cleanup] Race constants refactor #3782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time we only grepped for old definitions with the prefix of Output
|
Kinglykrab
approved these changes
Dec 19, 2023
hgtw
reviewed
Dec 22, 2023
hgtw
approved these changes
Dec 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helping Kingly in PR review #3763 (comment)
The previous PR does too many sweeping changes at once, has errors and makes it hard to merge / review / dissect / revert
Suggestions
This current branch only does race constants. It uses a small Go app located in
./utils/raceconstantrename/
- keep in mind the app is quick and dirty but does the job very accurately.Race
namespace definitions (transplanted manually)This is to ensure 100% accuracy in the constant migration. It makes this change far easier to review, revert, merge etc.
Kingly if you want to take PR credit and recut this branch using the script by all means - I just care more that we minimize issues with this large of change.