Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database] Update faction mods with Live data #3799

Merged
merged 1 commit into from Dec 23, 2023
Merged

Conversation

joligario
Copy link
Contributor

@joligario joligario commented Dec 22, 2023

Optional update to bring database up-to-date with Live data which includes Froglok and Drakkin data which was previously missing. Adds 999 new entries. Raw data can be found in the Live client at Resources\Faction\FactionAssociations.txt.

Creates a backup of the existing data at faction_list_mod_backup_23122 which can be deleted if satisfied with the updates.

See discussion at #3678

Optional update to bring database up-to-date with Live data which includes Froglok and Drakkin data which was previously missing.
Raw data can be found in the Live client at Resources\Faction\FactionAssociations.txt
See discussion at #3678
@noudess
Copy link
Contributor

noudess commented Dec 22, 2023

Looks good for stock databases. If you've made changes or additions to the base table (Rolath has identified several new factions that are not exposed by the client) then you will want to change this to only overwrite core stuff.

Copy link
Contributor

@noudess noudess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for systems that have no custom mods or additions. Those that do might want to modify sql to overwrite standard stuff.

I would not want this added to required and be automated.

@Akkadius
Copy link
Member

Looks good for systems that have no custom mods or additions. Those that do might want to modify sql to overwrite standard stuff.

I would not want this added to required and be automated.

Required updates are only schema or DDL changes these days - no content changes

@Akkadius Akkadius merged commit 556af8c into master Dec 23, 2023
2 checks passed
@Akkadius Akkadius deleted the faction_mod_update branch December 23, 2023 03:34
@Akkadius Akkadius mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants