Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Gender constants cleanup #3817

Merged
merged 2 commits into from
Dec 30, 2023
Merged

[Cleanup] Gender constants cleanup #3817

merged 2 commits into from
Dec 30, 2023

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Convert to a Gender namespace using constexpr.
  • Cleanup spots where we were using magic numbers for gender values.

@Kinglykrab
[Cleanup] Gender constants cleanup
38b07ed 
# Notes
- Convert to a `Gender` namespace using `constexpr`.
- Cleanup spots where we were using magic numbers for gender values.
@Kinglykrab
Cleanup
cda8b5e
@Kinglykrab Kinglykrab merged commit 4712ca4 into master Dec 30, 2023
2 checks passed
@Kinglykrab Kinglykrab deleted the cleanup/gender_constants branch December 30, 2023 16:22
@joligario joligario mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joligario joligario joligario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @joligario