Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands] Add scoped buckets and editing to #databuckets #3826

Merged
merged 3 commits into from Jan 7, 2024
Merged

[Commands] Add scoped buckets and editing to #databuckets #3826

merged 3 commits into from Jan 7, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Dec 30, 2023 •
edited

Notes

  • Cleanup messages and logic.
  • Utilize keyed buckets functionality optionally.
  • Use repositories instead of a regular query.
  • Added edit capability.

Usage Menu

image

Delete

image

Edit

image
image

View

image

@Kinglykrab
[Commands] Cleanup #databuckets Command
e0ca454 
# Notes
- Cleanup messages and logic.
- Utilize keyed buckets functionality optionally.
- Use repositories instead of a regular query.
@Kinglykrab
Add edit.
e4b437a
Akkadius
Akkadius requested changes Dec 31, 2023
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to see testing screens. When we're changing commands we've had many trivial issues pop up that could be caught in simple manual testing

@Kinglykrab
Copy link
Contributor Author

Will upload more, but these are what I sent to show @fryguy503 in Discord.

Edit

image
image

@Akkadius Akkadius changed the title [Commands] Cleanup #databuckets Command [Commands] Add scoped buckets and editing to #databuckets Jan 7, 2024
@Akkadius Akkadius merged commit 43c4b13 into master Jan 7, 2024
2 checks passed
@Akkadius Akkadius deleted the commands/databuckets_cleanup branch January 7, 2024 04:10
@Akkadius Akkadius mentioned this pull request Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Akkadius