[Item Ticks] Remove Item Ticks Code #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akkadius
reviewed
Jan 12, 2024
Akkadius
reviewed
Jan 12, 2024
Akkadius
requested changes
Jan 12, 2024
Kinglykrab
changed the title
Kinglykrab
force-pushed
the
items/load_item_ticks
branch
from
2172a2e
to
31f2347
Compare
- Convert `LoadItemTicks()` to repositories.
Kinglykrab
force-pushed
the
items/load_item_ticks
branch
from
0617197
to
7d9c0b4
Compare
Akkadius
approved these changes
Jan 13, 2024
Kinglykrab
added a commit
that referenced
this pull request
Jan 13, 2024
### AAs * Convert Loading of AAs to Repositories ([#3963](#3963)) @Kinglykrab 2024-01-13 ### Auras * Convert Get of Auras to Repositories ([#3964](#3964)) @Kinglykrab 2024-01-13 ### Character * Character EXP Modifiers in Memory ([#3934](#3934)) @Kinglykrab 2024-01-13 * Convert Character Corpses to Repositories ([#3941](#3941)) @Kinglykrab 2024-01-13 * Convert Save of Character Languages to Repositories ([#3948](#3948)) @Kinglykrab 2024-01-12 ### Code * Cleanup AddCash() and RemoveCash() NPC Methods ([#3957](#3957)) @Kinglykrab 2024-01-12 * Cleanup ChangeSize() ([#3959](#3959)) @Kinglykrab 2024-01-12 * Cleanup Owner Related Mob Methods ([#3960](#3960)) @Kinglykrab 2024-01-13 * Cleanup RandomizeFeatures() ([#3958](#3958)) @Kinglykrab 2024-01-12 * Remove GroupCount() and RaidGroupCount() ([#3943](#3943)) @Kinglykrab 2024-01-13 * Remove unused Grid methods ([#3944](#3944)) @Kinglykrab 2024-01-13 ### Commands * Convert NPC Spawn Methods to Repositories ([#3956](#3956)) @Kinglykrab 2024-01-13 ### Crash Fix * Character Creation Class/Race out of Range. ([#3920](#3920)) @fryguy503 2024-01-09 ### Feat * Alt Sinister Strike Formula ([#3921](#3921)) @fryguy503 2024-01-09 ### Feature * Add Lore Item Trade Error ([#3932](#3932)) @fryguy503 2024-01-13 * Rule: UseLiveBlockedMessage Bard Spam ([#3933](#3933)) @fryguy503 2024-01-09 ### Fixes * Attack Corpse Skill Up Fix ([#3924](#3924)) @fryguy503 2024-01-09 * Fix Issue with SetFlyMode() ([#3961](#3961)) @Kinglykrab 2024-01-12 * Harm Touch Critical Ratio ([#3915](#3915)) @fryguy503 2024-01-09 * Increase Precision in CheckDoubleAttack ([#3928](#3928)) @fryguy503 2024-01-09 * IsOfClientBotMerc() for Discipline Messages ([#3940](#3940)) @fryguy503 2024-01-09 * Limit MeleeMitigationEffect to defender if only client. ([#3918](#3918)) @fryguy503 2024-01-09 * Rampage Number of Hits Limit ([#3929](#3929)) @fryguy503 2024-01-09 * Remove duplicate character_data repository in zonedb.cpp ([#3935](#3935)) @Kinglykrab 2024-01-09 * Undead Should Never Flee ([#3926](#3926)) @fryguy503 2024-01-09 ### Global Loot * Convert Global Loot to Repositories ([#3962](#3962)) @Kinglykrab 2024-01-13 ### Ground Spawns * Convert Ground Spawns to Repositories ([#3967](#3967)) @Kinglykrab 2024-01-13 ### Horses * Convert Horses to Repositories ([#3965](#3965)) @Kinglykrab 2024-01-13 ### Item Ticks * Remove Item Ticks Code ([#3955](#3955)) @Kinglykrab 2024-01-13 ### Mercenaries * Convert Mercenaries to Repositories ([#3947](#3947)) @Kinglykrab 2024-01-13 ### Merchants * Convert Clear/Delete/Save of Temporary Merchant Lists to Repositories ([#3945](#3945)) @Kinglykrab 2024-01-13 ### NPCs * Convert Load of NPC Emotes to Repositories ([#3954](#3954)) @Kinglykrab 2024-01-13 ### Objects * Convert Add/Delete/Update of Objects to Repositories ([#3966](#3966)) @Kinglykrab 2024-01-13 * Convert World Containers to Repositories ([#3951](#3951)) @Kinglykrab 2024-01-13 ### Pets * Convert Pets to Repositories ([#3968](#3968)) @Kinglykrab 2024-01-13 ### Repositories * Add null integer column support, instance_list notes migration, regenerate repositories ([#3969](#3969)) @Akkadius 2024-01-13 ### Respawns * Convert Respawn Times to Repositories ([#3949](#3949)) @Kinglykrab 2024-01-13 ### Rules * Add rule for bard aggro cap ([#3909](#3909)) @fryguy503 2024-01-09 * Allow GMs to silently summon ([#3910](#3910)) @fryguy503 2024-01-09 * Bash Two Hander use Shoulders ([#3925](#3925)) @fryguy503 2024-01-09 * Classic Spell Data SPA Calc variability ([#3931](#3931)) @fryguy503 2024-01-09 * Classic Tracking Skillups ([#3923](#3923)) @fryguy503 2024-01-09 * Separate Tradeskill Max Train from Research. ([#3916](#3916)) @fryguy503 2024-01-09 ### Tasks * Add Support for Task Window Element Groups ([#3902](#3902)) @hgtw 2024-01-09 ### Traps * Convert Load of LDoN Traps/Trap Entries to Repositories ([#3953](#3953)) @Kinglykrab 2024-01-13 ### Zones * Convert Get/Set of Zone Timezone to Repositories ([#3946](#3946)) @Kinglykrab 2024-01-13 * Convert IDLE_WHEN_EMPTY to a Zone Column ([#3891](#3891)) @Kinglykrab 2024-01-13 * Convert SaveZoneCFG to Repositories ([#3950](#3950)) @Kinglykrab 2024-01-13
Merged
Akkadius
pushed a commit
that referenced
this pull request
Jan 13, 2024
### AAs * Convert Loading of AAs to Repositories ([#3963](#3963)) @Kinglykrab 2024-01-13 ### Auras * Convert Get of Auras to Repositories ([#3964](#3964)) @Kinglykrab 2024-01-13 ### Character * Character EXP Modifiers in Memory ([#3934](#3934)) @Kinglykrab 2024-01-13 * Convert Character Corpses to Repositories ([#3941](#3941)) @Kinglykrab 2024-01-13 * Convert Save of Character Languages to Repositories ([#3948](#3948)) @Kinglykrab 2024-01-12 ### Code * Cleanup AddCash() and RemoveCash() NPC Methods ([#3957](#3957)) @Kinglykrab 2024-01-12 * Cleanup ChangeSize() ([#3959](#3959)) @Kinglykrab 2024-01-12 * Cleanup Owner Related Mob Methods ([#3960](#3960)) @Kinglykrab 2024-01-13 * Cleanup RandomizeFeatures() ([#3958](#3958)) @Kinglykrab 2024-01-12 * Remove GroupCount() and RaidGroupCount() ([#3943](#3943)) @Kinglykrab 2024-01-13 * Remove unused Grid methods ([#3944](#3944)) @Kinglykrab 2024-01-13 ### Commands * Convert NPC Spawn Methods to Repositories ([#3956](#3956)) @Kinglykrab 2024-01-13 ### Crash Fix * Character Creation Class/Race out of Range. ([#3920](#3920)) @fryguy503 2024-01-09 ### Feat * Alt Sinister Strike Formula ([#3921](#3921)) @fryguy503 2024-01-09 ### Feature * Add Lore Item Trade Error ([#3932](#3932)) @fryguy503 2024-01-13 * Rule: UseLiveBlockedMessage Bard Spam ([#3933](#3933)) @fryguy503 2024-01-09 ### Fixes * Attack Corpse Skill Up Fix ([#3924](#3924)) @fryguy503 2024-01-09 * Fix Issue with SetFlyMode() ([#3961](#3961)) @Kinglykrab 2024-01-12 * Harm Touch Critical Ratio ([#3915](#3915)) @fryguy503 2024-01-09 * Increase Precision in CheckDoubleAttack ([#3928](#3928)) @fryguy503 2024-01-09 * IsOfClientBotMerc() for Discipline Messages ([#3940](#3940)) @fryguy503 2024-01-09 * Limit MeleeMitigationEffect to defender if only client. ([#3918](#3918)) @fryguy503 2024-01-09 * Rampage Number of Hits Limit ([#3929](#3929)) @fryguy503 2024-01-09 * Remove duplicate character_data repository in zonedb.cpp ([#3935](#3935)) @Kinglykrab 2024-01-09 * Undead Should Never Flee ([#3926](#3926)) @fryguy503 2024-01-09 ### Global Loot * Convert Global Loot to Repositories ([#3962](#3962)) @Kinglykrab 2024-01-13 ### Ground Spawns * Convert Ground Spawns to Repositories ([#3967](#3967)) @Kinglykrab 2024-01-13 ### Horses * Convert Horses to Repositories ([#3965](#3965)) @Kinglykrab 2024-01-13 ### Item Ticks * Remove Item Ticks Code ([#3955](#3955)) @Kinglykrab 2024-01-13 ### Mercenaries * Convert Mercenaries to Repositories ([#3947](#3947)) @Kinglykrab 2024-01-13 ### Merchants * Convert Clear/Delete/Save of Temporary Merchant Lists to Repositories ([#3945](#3945)) @Kinglykrab 2024-01-13 ### NPCs * Convert Load of NPC Emotes to Repositories ([#3954](#3954)) @Kinglykrab 2024-01-13 ### Objects * Convert Add/Delete/Update of Objects to Repositories ([#3966](#3966)) @Kinglykrab 2024-01-13 * Convert World Containers to Repositories ([#3951](#3951)) @Kinglykrab 2024-01-13 ### Pets * Convert Pets to Repositories ([#3968](#3968)) @Kinglykrab 2024-01-13 ### Repositories * Add null integer column support, instance_list notes migration, regenerate repositories ([#3969](#3969)) @Akkadius 2024-01-13 ### Respawns * Convert Respawn Times to Repositories ([#3949](#3949)) @Kinglykrab 2024-01-13 ### Rules * Add rule for bard aggro cap ([#3909](#3909)) @fryguy503 2024-01-09 * Allow GMs to silently summon ([#3910](#3910)) @fryguy503 2024-01-09 * Bash Two Hander use Shoulders ([#3925](#3925)) @fryguy503 2024-01-09 * Classic Spell Data SPA Calc variability ([#3931](#3931)) @fryguy503 2024-01-09 * Classic Tracking Skillups ([#3923](#3923)) @fryguy503 2024-01-09 * Separate Tradeskill Max Train from Research. ([#3916](#3916)) @fryguy503 2024-01-09 ### Tasks * Add Support for Task Window Element Groups ([#3902](#3902)) @hgtw 2024-01-09 ### Traps * Convert Load of LDoN Traps/Trap Entries to Repositories ([#3953](#3953)) @Kinglykrab 2024-01-13 ### Zones * Convert Get/Set of Zone Timezone to Repositories ([#3946](#3946)) @Kinglykrab 2024-01-13 * Convert IDLE_WHEN_EMPTY to a Zone Column ([#3891](#3891)) @Kinglykrab 2024-01-13 * Convert SaveZoneCFG to Repositories ([#3950](#3950)) @Kinglykrab 2024-01-13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes