[Skill Caps] Remove from shared memory and simplify #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! We'll need some testers around this |
|
Still need to get testing for this |
|
You need to coordinate testing for this so we can close the loop, needs rebasing as well. |
Kinglykrab
force-pushed
the
skill_caps/shared_memory_remove
branch
from
638b7d9
to
1e48238
Compare
- Removes Skill Caps loading from shared memory and puts it into zone. - Adds `id` column to `skill_caps`. - Remove primary keys and use `id` as primary key. - Add unique index using `skill_id`, `class_id`, `level`, and `cap`. - Renames `class` to `class_id` in `skill_caps` table. - Renames `skillID` to `skill_id` in `skill_caps` table. - Regenerates Skill Caps repository. - Adds `#reload skill_caps` to reload skill caps in real time.
Kinglykrab
force-pushed
the
skill_caps/shared_memory_remove
branch
from
8e9a1ba
to
f589c70
Compare
Akkadius
approved these changes
Mar 23, 2024
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Apr 15, 2024
* [Skill Caps] Remove from shared memory and simplify - Removes Skill Caps loading from shared memory and puts it into zone. - Adds `id` column to `skill_caps`. - Remove primary keys and use `id` as primary key. - Add unique index using `skill_id`, `class_id`, `level`, and `cap`. - Renames `class` to `class_id` in `skill_caps` table. - Renames `skillID` to `skill_id` in `skill_caps` table. - Regenerates Skill Caps repository. - Adds `#reload skill_caps` to reload skill caps in real time. * Update groups.cpp * Update groups.cpp
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
idcolumn toskill_caps.idas primary key.skill_id,class_id,level, andcap.classtoclass_idinskill_capstable.skillIDtoskill_idinskill_capstable.#reload skill_capsto reload skill caps in real time.Video
Screencast.from.03-23-2024.04.01.17.PM.webm