[Bug Fix] Fix Bot/Character ID Overlap in Groups #4093
Conversation
|
This is going to need some thorough testing done |
Yeah, I’d like if Karana could test it as well as Lancelot Jim. |
|
Good afternoon @Kinglykrab. I ran some tests and did not have any problems zoning in a group with a bot that shared the id of the character. My test was a player(44) and two bots; bot1(44) bot(46). I did notice that I was not able to invite another players' bot. I could send the group invite, but they never joined the group. Not sure if that is intended or not. The other player shared a its id with the bot(1). I also tested within a raid. No issue. Once in the raid, I moved the other player and their bots to the same group, worked fine. Zoned, no issues anywhere. |
Hmmm, I didn't try inviting another player's bots, but I think you have to invite the owner. |
Kinglykrab
force-pushed
the
bug_fix/bot_character_id_overlap
branch
from
a8c92cd
to
ac64a78
Compare
|
I tried both single and with the owner already in the group. Same result, no dice, though not sure if it ever worked. |
|
What's the status on this? |
Just need to wait on other stuff to be merged so this can be rebased without rebasing it multiple times. I've tested it on my end and it seems to resolve the issue. |
- Attempt to fix bot/character ID overlap in groups keeping bots with the same unique identifier as players from not spawning on zone. - Adds `bot_id` to `group_id` to differentiate bots from characters and hopefully alleviate this issue.
Kinglykrab
force-pushed
the
bug_fix/bot_character_id_overlap
branch
from
8b2b714
to
3704726
Compare
|
Has anyone tested bot creation on this PR? Not sure if it's related or not but we're getting a "Failed to query name availability" with this. |
* [Bug Fix] Fix Bot/Character ID Overlap in Groups - Attempt to fix bot/character ID overlap in groups keeping bots with the same unique identifier as players from not spawning on zone. - Adds `bot_id` to `group_id` to differentiate bots from characters and hopefully alleviate this issue. * Update base_group_id_repository.h * Final push
Notes
bot_idtogroup_idto differentiate bots from characters and hopefully alleviate this issue.