[Bug Fix] /who all displays incorrect guild name. /who works fine #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: guild creation routine does not update world memory holding guild details until the player zones. Between the creation of a new guild, and a guild member zones, a /who all displays 'Invalid Guild' instead of the actual guild name.
Kinglykrab
approved these changes
Feb 25, 2024
Kinglykrab
changed the title
joligario
added a commit
that referenced
this pull request
Feb 29, 2024
### Character Creation * Improved Random Name Generator ([#4081](#4081)) @catapultam-habeo 2024-02-27 ### Code * Fix Server Rules Documentation Generation ([#4125](#4125)) @Kinglykrab 2024-02-26 * Remove unnecessary stoptimer logs ([#4128](#4128)) @Kinglykrab 2024-02-28 ### Commands * Add `#forage` command ([#4133](#4133)) @joligario 2024-02-29 ### Crash * Fix crash issue during database dump ([#4127](#4127)) @Akkadius 2024-02-29 ### Crash Fix * D20 crash if mitigation average resulted in 0 ([#4131](#4131)) @nytmyr 2024-02-29 ### Fixes * Fix forage returning first result from table ([#4130](#4130)) @nytmyr 2024-02-29 * Who /all displays incorrect guild name ([#4123](#4123)) @neckkola 2024-02-25 ### Quest API * Add Pet Owner Methods to Perl/Lua ([#4115](#4115)) @Kinglykrab 2024-02-25
Merged
Kinglykrab
pushed a commit
that referenced
this pull request
Feb 29, 2024
### Character Creation * Improved Random Name Generator ([#4081](#4081)) @catapultam-habeo 2024-02-27 ### Code * Fix Server Rules Documentation Generation ([#4125](#4125)) @Kinglykrab 2024-02-26 * Remove unnecessary stoptimer logs ([#4128](#4128)) @Kinglykrab 2024-02-28 ### Commands * Add `#forage` command ([#4133](#4133)) @joligario 2024-02-29 ### Crash * Fix crash issue during database dump ([#4127](#4127)) @Akkadius 2024-02-29 ### Crash Fix * D20 crash if mitigation average resulted in 0 ([#4131](#4131)) @nytmyr 2024-02-29 ### Fixes * Fix forage returning first result from table ([#4130](#4130)) @nytmyr 2024-02-29 * Who /all displays incorrect guild name ([#4123](#4123)) @neckkola 2024-02-25 ### Quest API * Add Pet Owner Methods to Perl/Lua ([#4115](#4115)) @Kinglykrab 2024-02-25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a guild and immediately do a /who all, the guild tag in the displayed info is 'Invalid Guild' instead of the actual guild name. A /who displays the correct guild tag.
Issue: The guild creation routine is not updating world memory immediately. It does update when a permission is changed, a guild rank name is changed, or the player zones.