[Crash Fix] Update to location of qGlobals initialization #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
approved these changes
Mar 2, 2024
Akkadius
approved these changes
Mar 2, 2024
|
Love to see crash fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error log from Spire id 19626 fingerprint a7bba against 22.45.0
Setting the rule Character:PerCharacterQglobalMaxLevel to true would cause zone.exe to crash on character login.
qGlobals was not being initialized before it was being used in the routine resulting in the nullptr check to fail.
Relocated the initialization to before the routine.