[Crash Fix] Goto command could crash using dev tools #4158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a crash situation using dev tools and the goto command.
Reproduction:
#zone akanon
#list npcs
scroll through the list and click the 'goto' for Zenrel Ottonoggin
zone would crash.
Traced to the check on sep->arg[4] which was "" though returning true in the check. Setup a std::string object to test for emptiness. Resolved the issue.