Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quest API] Add Buff Support to Perl/Lua #4182

Merged
merged 4 commits into from Mar 14, 2024
Merged

[Quest API] Add Buff Support to Perl/Lua #4182

merged 4 commits into from Mar 14, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Mar 10, 2024 •
edited

Perl

  • Add $buff->GetCasterID().
  • Add $buff->GetCasterLevel().
  • Add $buff->GetCasterName().
  • Add $buff->GetCastOnX().
  • Add $buff->GetCastOnY().
  • Add $buff->GetCastOnZ().
  • Add $buff->GetCounters().
  • Add $buff->GetDOTRune().
  • Add $buff->GetExtraDIChance().
  • Add $buff->GetInstrumentModi().
  • Add $buff->GetMagicRune().
  • Add $buff->GetMeleeRune().
  • Add $buff->GetNumberOfHits().
  • Add $buff->GetRootBreakChanc().
  • Add $buff->GetSpellID().
  • Add $buff->GetTicsRemaining().
  • Add $buff->GetVirusSpreadTim().
  • Add $buff->IsCasterClient().
  • Add $buff->IsPersistentBuff().
  • Add $buff->SendsClientUpdate().

Lua

  • Add buff:GetCasterID().
  • Add buff:GetCasterLevel().
  • Add buff:GetCasterName().
  • Add buff:GetCastOnX().
  • Add buff:GetCastOnY().
  • Add buff:GetCastOnZ().
  • Add buff:GetCounters().
  • Add buff:GetDOTRune().
  • Add buff:GetExtraDIChance().
  • Add buff:GetInstrumentModi().
  • Add buff:GetMagicRune().
  • Add buff:GetMeleeRune().
  • Add buff:GetNumberOfHits().
  • Add buff:GetRootBreakChanc().
  • Add buff:GetSpellID().
  • Add buff:GetTicsRemaining().
  • Add buff:GetVirusSpreadTim().
  • Add buff:IsCasterClient().
  • Add buff:IsPersistentBuff().
  • Add buff:SendsClientUpdate().

Notes

  • Adds support for Buffs_Struct to Perl/Lua.
  • Allows operators to read a buff's buff data directly to determine caster, melee rune, etc.

@Kinglykrab
[Quest API] Add Buff Support to Perl/Lua
622ca2a 
- Add `$mob->GetCasterID()`.
- Add `$mob->GetCasterLevel()`.
- Add `$mob->GetCasterName()`.
- Add `$mob->GetCastOnX()`.
- Add `$mob->GetCastOnY()`.
- Add `$mob->GetCastOnZ()`.
- Add `$mob->GetCounters()`.
- Add `$mob->GetDOTRune()`.
- Add `$mob->GetExtraDIChance()`.
- Add `$mob->GetInstrumentModi()`.
- Add `$mob->GetMagicRune()`.
- Add `$mob->GetMeleeRune()`.
- Add `$mob->GetNumberOfHits()`.
- Add `$mob->GetRootBreakChanc()`.
- Add `$mob->GetSpellID()`.
- Add `$mob->GetTicsRemaining()`.
- Add `$mob->GetVirusSpreadTim()`.
- Add `$mob->IsCasterClient()`.
- Add `$mob->IsPersistentBuff()`.
- Add `$mob->SendsClientUpdate()`.

- Add `mob:GetCasterID()`.
- Add `mob:GetCasterLevel()`.
- Add `mob:GetCasterName()`.
- Add `mob:GetCastOnX()`.
- Add `mob:GetCastOnY()`.
- Add `mob:GetCastOnZ()`.
- Add `mob:GetCounters()`.
- Add `mob:GetDOTRune()`.
- Add `mob:GetExtraDIChance()`.
- Add `mob:GetInstrumentModi()`.
- Add `mob:GetMagicRune()`.
- Add `mob:GetMeleeRune()`.
- Add `mob:GetNumberOfHits()`.
- Add `mob:GetRootBreakChanc()`.
- Add `mob:GetSpellID()`.
- Add `mob:GetTicsRemaining()`.
- Add `mob:GetVirusSpreadTim()`.
- Add `mob:IsCasterClient()`.
- Add `mob:IsPersistentBuff()`.
- Add `mob:SendsClientUpdate()`.

- Adds support for `Buffs_Struct` to Perl/Lua.
- Allows operators to read a mob's buff data directly to determine caster, melee rune, etc.
@Kinglykrab
Fix GetCasterID() to proper data type.
a93bda1
hgtw
hgtw reviewed Mar 14, 2024
View reviewed changes
zone/lua_mob.cpp Outdated Show resolved Hide resolved
@Kinglykrab Kinglykrab requested a review from hgtw March 14, 2024 01:57
@Kinglykrab Kinglykrab merged commit 161c13f into master Mar 14, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the quest_api/buff_support branch March 14, 2024 03:38
@Akkadius Akkadius mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgtw hgtw hgtw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @hgtw