[Bug Fix] Fix EVENT_KILLED_MERIT firing before NPC removal #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was @Kinglykrab |
Yes because we loop this logic multiple times in Death |
|
Gotcha, I know KK wanted feedback on this, I have the version without the lua/perl defs and so far its working great |
hgtw
reviewed
Mar 17, 2024
hgtw
reviewed
Mar 17, 2024
# Notes - NPCs were parsing this event too early and anything that checked if they were still alive in `EVENT_KILLED_MERIT` would show them still alive because of this. # Image
Kinglykrab
force-pushed
the
bug_fix/event_killed_merit
branch
from
8db22ef
to
a5ac593
Compare
hgtw
reviewed
Mar 17, 2024
hgtw
approved these changes
Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl
$client->GetGroupOrRaidOrSelf().$client->GetGroupOrRaidOrSelf(clients_only).Lua
client:GetGroupOrRaidOrSelf().client:GetGroupOrRaidOrSelf(clients_only).Notes
EVENT_KILLED_MERITwould show them still alive because of this.Image