Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix Auto Login Issue #4213

Merged
merged 2 commits into from Mar 28, 2024
Merged

[Bug Fix] Fix Auto Login Issue #4213

merged 2 commits into from Mar 28, 2024

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • We were setting live_name value regardless of if we were zoning, causing us to automatically log in to the last character we'd logged in to before.
  • Thanks @neckkola for this.

# Notes
- We were setting `live_name` value regardless of if we were zoning, causing us to automatically log in to the last character we'd logged in to before.
@Kinglykrab Kinglykrab marked this pull request as ready for review March 28, 2024 03:33
Copy link
Contributor

@joligario joligario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need the change to client.cpp anymore after removing reference type

Ah, disregard. Dropped the const. Didn't notice that on my phone.

@Kinglykrab Kinglykrab merged commit f905ee7 into master Mar 28, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the bug_fix/auto_login branch March 28, 2024 13:48
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Apr 15, 2024
* [Bug Fix] Fix Auto Login Issue

# Notes
- We were setting `live_name` value regardless of if we were zoning, causing us to automatically log in to the last character we'd logged in to before.

* Remove &
@Akkadius Akkadius mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants