Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Check mob pointer before trying to remove it #4230

Merged
merged 1 commit into from Apr 1, 2024

Conversation

Akkadius
Copy link
Member

@Akkadius Akkadius commented Mar 31, 2024

Description

This attempts to check a pointer before trying to do book keeping. We are observing a crashing during zone shutdown during RemoveAllMobs that is unclear the exact source of the trigger

Attempts to fix crash fingerprint 10444 which has over 100 occurrences at this point https://spire.akkadius.com/dev/release/22.48.0?id=20718

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Had 3 zones shutdown that trigger RemoveAllMobs

image

image

image

  • Currently running and baking on PEQ. Seems to have helped the crashes.
  • This should be tested and baked on a server with players such as PEQ to confirm it doesn't create other issues

Clients tested: ROF2

Checklist

  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have tested my changes
  • I have made corresponding changes to the documentation
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius force-pushed the akkadius/mob-pointer-checking branch from b54af2f to 93a3d11 Compare April 1, 2024 03:52
@Kinglykrab Kinglykrab merged commit 3a5381d into master Apr 1, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the akkadius/mob-pointer-checking branch April 1, 2024 22:09
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Apr 15, 2024
@Akkadius Akkadius mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants