Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix Lua Crash with Spell Blocked Event #4236

Merged
merged 1 commit into from Apr 1, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Apr 1, 2024

Description

  • A Lua crash was occurring because there was no indication the event_spell_blocked line existed, so when attempting to get the event's name by its ID it was failing per @KayenEQ's log.
  • Occurred when resolving merge conflicts in the original pull request.

Log

[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\lua_parser.cpp (881): LuaParser::GlobalPlayerHasQuestSub 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\quest_parser_collection.cpp (229): QuestParserCollection::PlayerHasQuestSubGlobal 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\quest_parser_collection.cpp (185): QuestParserCollection::PlayerHasQuestSub 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spells.cpp (3579): Mob::AddBuff 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spell_effects.cpp (125): Mob::SpellEffect 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spells.cpp (4526): Mob::SpellOnTarget 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spells.cpp (2591): Mob::SpellFinished 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spells.cpp (1743): Mob::CastedSpellFinished 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\spells.cpp (134): Mob::SpellProcess 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\client_process.cpp (500): Client::Process 
[04-01-2024 14:08:10] [Zone] [Crash] C:\git-eqemulator\Server\zone\entity.cpp (544): EntityList::MobProcess

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing

@KayenEQ confirmed he no longer crashes with this fix implemented.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab marked this pull request as ready for review April 1, 2024 18:28
@Kinglykrab Kinglykrab merged commit e64f03f into master Apr 1, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the bug_fix/lua_crash_spell_blocked_event branch April 1, 2024 22:06
@Kinglykrab Kinglykrab restored the bug_fix/lua_crash_spell_blocked_event branch April 1, 2024 22:24
@Kinglykrab Kinglykrab deleted the bug_fix/lua_crash_spell_blocked_event branch April 1, 2024 22:24
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Apr 15, 2024
@Akkadius Akkadius mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants