[Bug Fix] SPA214 SE_MaxHPChange calculation errors corrected. #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: When an HP buff with a heal effect is applied for first time, the heal portion of the effect heals the client and updates HPs currently server side, but client side the HP bar does not register it as a heal thus you display as less than full HP. However due to server thinking your healed, you are unable to correct it by healing. Solution: You need to resend the HP update after buff completed and action packet resent.
would result in same bug
Fix how spell and item bonuses using SPA 214 are calculated. Will now be calculated consistent with client.
Kinglykrab
reviewed
Apr 1, 2024
removed code from other PR
Kinglykrab
approved these changes
Apr 1, 2024
Akkadius
approved these changes
Apr 2, 2024
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Apr 15, 2024
…4238) * [Bug Fix] HP Bar not updating when applying HP Buff with a heal. Bug: When an HP buff with a heal effect is applied for first time, the heal portion of the effect heals the client and updates HPs currently server side, but client side the HP bar does not register it as a heal thus you display as less than full HP. However due to server thinking your healed, you are unable to correct it by healing. Solution: You need to resend the HP update after buff completed and action packet resent. * add SE_MaxHPChange to fix would result in same bug * [Bug Fix] SPA214 Percent HP change calculation fix Fix how spell and item bonuses using SPA 214 are calculated. Will now be calculated consistent with client. * [Bug Fix] SPA214 SE_MaxHPChange calculation errors corrected. removed code from other PR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: SPA 214 which changes hit points by percentage was not displaying correctly on the client. This was causing differences between client displayed hit points and server calculations.
Solution: The formula we were using to apply the spell and item bonuses using SPA 214 to client max hit points was incorrect. It should not have been applying it after the AA version (Natural Durability) and after Spell HP buffs (Ie. Virtue). The correct calculation was it should be applied at the same time as the AA version.
Client and server now display the same values within 5 hps of each other.
Fixed for Bots and Mercs as well.