[Bug Fix] Hero forge armor bug on login and show helm toggle.

[noudess]

Description

1. Other clients witnessing a new client that is wearing Hero Forge armor would not see the armor until a zone or re-equip.
2. A character wearing hero forge armor on head would lose the model when toggling show helm.

HELP!!
This fix potentially removes the need for the heroforge_wearchange_timer which is set in Client::CompleteConnect(). Changing that timer to be longer also fixes the problem, but was not the root cause. I would love some expert opinion on if taking that timer out completely is advisable.

@KayenEQ

#1883

HELP!!

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Testing

Video showing bug here.
Video showing fix here.

Clients tested: ROF2

Checklist

• I have tested my changes
• I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
• I own the changes of my code and take responsibility for the potential issues that occur

[KayenEQ]

If that change solves the root issue and it looks like it does then by all means get rid of the timer. I only coded it like that cause I couldn't figure out the underlying problem at the time and by delaying the packet a few milliseconds it seemed to resolve the issue for me.

[KayenEQ]

I tested the change myself. I couldn't find any issues with other clients seeing heroforge armor on zone in or on item swaps.
I reverted the timer changes and put the wearchange send back in client connect where it originally was. With this fix it appears that sending the wearchange on client connect doesn't affect heroforge visibility. However, I don't know if there were other situations that require that code to be present, so to avoid other potential issues thus I recommended just keeping it in place.

[noudess]

I tested the change myself. I couldn't find any issues with other clients seeing heroforge armor on zone in or on item swaps. I reverted the timer changes and put the wearchange send back in client connect where it originally was. With this fix it appears that sending the wearchange on client connect doesn't affect heroforge visibility. However, I don't know if there were other situations that require that code to be present, so to avoid other potential issues thus I recommended just keeping it in place.

Did as you asked.