Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highs_setOptionValue unimplemented #223

Closed
matbesancon opened this issue Dec 2, 2019 · 3 comments
Closed

Highs_setOptionValue unimplemented #223

matbesancon opened this issue Dec 2, 2019 · 3 comments
Assignees

Comments

@matbesancon
Copy link
Contributor

I don't find any implementation of the Highs_setOptionValue function, which is only defined in the C interface but not in the shared object.

@mlubin
Copy link
Contributor

mlubin commented Apr 2, 2020

@jajhall, d23eca2 appears to have addressed this issue. Should we start adapting the Julia wrapper or should we wait for more changes?

@jajhall
Copy link
Member

jajhall commented Apr 2, 2020

I didn't create a full set of getters and setters in the C interface. HiGHS has options of bool, int, double and string type. There are still only setters for int, double and string (as char*), and getters for int and double. I'm afraid my C/C++ skills aren't up to the others. Note that we created setHighsOptionValue in the C interface when we were going to pass all values of options as strings. In the C++ interface we now we allow them to be passed as bool, int, double, string by overloading the definition of setHighsOptionValue. In the C interface I created setHighsIntOptionValue, setHighsDoubleOptionValue and setHighsStringOptionValue to achieve the same functionality, leaving setHighsOptionValue rather than delete it from the API. I'll get @feldmeier on the case to do a proper job, but opinions from others would be welcome.

@feldmeier feldmeier self-assigned this Apr 3, 2020
@feldmeier
Copy link
Collaborator

I added the getter/setter for bool and the getter for string options in #299. For retrieving a string option the user needs to provide a pointer to a sufficient amount of memory. There is no good way of handling the memory allocation for the user in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants