AbstractAccessReferenceMap Issues #37 #329 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SThis test case consistently illustrates the race condition resulting from concurrent invocations of addDirectReference.
Synchronizing all public access methods to this wrapper class.
Updating class documentation to provide an example of multi-interaction synchronization syntax.
With primary synchronization being pushed to the class API level, there really is no benefit to maintaining the overhead of ConcurrentHashMap fields. The thread-safety guaranteed by the ConcurrentHashMap is superceeded by the public API of the abstract class, and should never actually be leveraged. This assumes that all sub-classes with extended public API continue the use of class-level synchronization.
Adding method which shows that it is possible to create a corrupted direct -> Indirect to Indirect -> Direct Object relationship when using the public update(Set) API.
Altering the logic of update behavior to avoid the possibility of the same indirect object being associated with multiple direct instances.
This was referenced Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential resolutions for two issues in AbstractAccessReferenceMap.
First, handling #329 I've provided a multi-threaded unit test which replicates the condition consistently. The offered solution is to add synchronized keyword to all public API of the AbstractAccessReferenceMap.
Second, #37 Provided a test which shows that in cases where subclasses return the same indirect key multiple times it can lead to corruption during update. Logic updates were made to the implementation to address.