Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractAccessReferenceMap Issues #37 #329 #469

Merged
merged 6 commits into from Jan 16, 2019
Merged

AbstractAccessReferenceMap Issues #37 #329 #469

merged 6 commits into from Jan 16, 2019

Commits on Jan 13, 2019

  1. Concurrency Test for AbstractAccessReferenceMap 

    SThis test case consistently illustrates the race condition resulting from
concurrent invocations of addDirectReference.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    968ae83 View commit details
    Browse the repository at this point in the history

  2. AbstractAccessReferenceMap Sync Updates 

    Synchronizing all public access methods to this wrapper class.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    4eb0643 View commit details
    Browse the repository at this point in the history

  3. AbstractAccessReferenceMap Class Documentation 

    Updating class documentation to provide an example of multi-interaction
synchronization syntax.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    8ed44ac View commit details
    Browse the repository at this point in the history

  4. AbstractAccessMap field updates to use HashMap 

    With primary synchronization being pushed to the class API level, there
really is no benefit to maintaining the overhead of ConcurrentHashMap
fields.  The thread-safety guaranteed by the ConcurrentHashMap is
superceeded by the public API of the abstract class, and should never
actually be leveraged.

This assumes that all sub-classes with extended public API continue the
use of class-level synchronization.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    27c2e56 View commit details
    Browse the repository at this point in the history

  5. AbstractAccessReferenceMapTest Extension 

    Adding method which shows that it is possible to create a corrupted direct
-> Indirect to Indirect -> Direct Object relationship when using the
public update(Set) API.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    c7ab789 View commit details
    Browse the repository at this point in the history

  6. AbstractAccessReferenceMap.update Logic Update 

    Altering the logic of update behavior to avoid the possibility of the same
indirect object being associated with multiple direct instances.
    @jeremiahjstacey
    jeremiahjstacey committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    6bb11e4 View commit details
    Browse the repository at this point in the history