Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transient ne30np4 cam tests to ne30np4.pg3 #1039

Closed
adamrher opened this issue May 21, 2024 · 12 comments
Closed

Change transient ne30np4 cam tests to ne30np4.pg3 #1039

adamrher opened this issue May 21, 2024 · 12 comments
Assignees
Labels
misc tag issue or PR candidate for upcoming misc tag

Comments

@adamrher
Copy link

adamrher commented May 21, 2024

Issue Type

Other (please describe below)

Issue Description

In CESM3, we are discontinuing transient cases (which require a landuse_timeseries file from CTSM) for "vanilla" se. Some of our existing cam tests are vanilla transient cases, causing test failures ESCOMP/CTSM#2549. I propose we replace all transient vanilla tests with pg3 tests to resolve these failures.

@PeterHjortLauritzen I would like your feedback on whether this is an acceptable resolution to the current test failures.

@fvitt @ekluzek @cacraigucar

Will this change answers?

No

Will you be implementing this yourself?

No

@adamrher adamrher changed the title Change transient neXXnp4 cam tests to neXXpg3 Change transient ne30np4 cam tests to ne30np4.pg3 May 21, 2024
@PeterHjortLauritzen
Copy link
Collaborator

Yes that sounds good to me

@cacraigucar cacraigucar added the misc tag issue or PR candidate for upcoming misc tag label May 23, 2024
@brian-eaton
Copy link
Collaborator

@adamrher, I think I just figured out that by "vanilla se" you're referring to SE without CSLAM. Yes?

@adamrher
Copy link
Author

Yes, sorry for not making that explicit. It is non-CSLAM spectral elements, so ne30np4, instead of ne30pg3.

@cacraigucar
Copy link
Collaborator

@brian-eaton - Are you currently working on these test failures (and updating them)?

ERP_Ln9.ne30_ne30_mg17.FCnudged.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
FAIL ERP_Ln9.ne30_ne30_mg17.FCnudged.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD failed to initialize
SMS_D_Ln9.ne16_ne16_mg17.FX2000.derecho_intel.cam-outfrq9s (Overall: PEND) details:
PEND SMS_D_Ln9.ne16_ne16_mg17.FX2000.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD
SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
PEND SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
PEND SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD

If not, we'll probably need to slip it into an upcoming tag (maybe your cam7 PR)?

@brian-eaton
Copy link
Collaborator

@cacraigucar, @adamrher. Two of the tests mentioned above are on variable grids. Looking in the grid description files I don't see anything that looks like a pg3 version of ne0ARCTICne30x4 or ne0CONUSne30x8. Does the variable grid use CSLAM?

@adamrher
Copy link
Author

adamrher commented Jun 7, 2024

It does not, CSLAM will not work with VR.

We have recently reached a compromise with the land group to support transient cases for VR (CONUS, ARCTIC and ARCTIGRIS) for the years 1979-2026. This transient support is not in the current ctsm external and I don't even think the PR has been opened -- it's on their to do list for CESM3. Is that accurate @ekluzek?

@ekluzek
Copy link

ekluzek commented Jun 7, 2024

@adamrher do you mean this one?

ESCOMP/CTSM#2490

That one has already been merged in. The only other one I could see an issue about the VR Dual polar grid.

We do also have an issue about handling the 1979-PD type datasets in a better way, but we do have it currently handled.

@adamrher
Copy link
Author

adamrher commented Jun 7, 2024

Oh my apologies everyone, the 1979-2026 transient support for CONUS, ARCTIC and ARCTICGRIS are in the current ctsm externals in cam6_3_160.

Dual polar support is on the to do list for me.

@brian-eaton
Copy link
Collaborator

Hi @adamrher, @ekluzek. I'm getting the following error from the FHIST test on the ARCTIC grid and from the FCHIST test on the CONUS grid based on externals in cam6_3_162:

CLM build-namelist::CLMBuildNamelist::setup_logic_initial_conditions() :
use_init_interp is NOT synchronized with init_interp_attributes in the
namelist_defaults file, this should be corrected there' 

My impression from the discussion above was that these tests should be working now. Is this a fix from CLM, or is the fix in how CAM sets up the run?

@ekluzek
Copy link

ekluzek commented Jun 14, 2024

@brian-eaton thanks for pointing this out. A general fix likely needs to come into CTSM.

A workaround that I think you can use in that version is to add this to user_nl_clm:

use_init_interp = .true.

If that doesn't work you might also need to explicitly add the finidat file to point to in addition to above.

@ekluzek
Copy link

ekluzek commented Jun 14, 2024

I did do I case tests for this in the version cam6_3_162 is using (ctsm5.2.007). So my main question to track this down is how our baseline tests are different from the tests that CAM is running? I want to make sure they are testing as close to the same thing as possible.

The tests I ran are here:

/glade/campaign/cgd/tss/ctsm_baselines/ctsm_sci-ctsm5.2.007/SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam6LndTuningMode_2013Start
/glade/campaign/cgd/tss/ctsm_baselines/ctsm_sci-ctsm5.2.007/SMS_Ln9.ne0ARCTICGRISne30x8_ne0ARCTICGRISne30x8_mt12.I1850Clm60BgcCrop.derecho_intel.clm-clm60cam6LndTuningMode
/glade/campaign/cgd/tss/ctsm_baselines/ctsm_sci-ctsm5.2.007/SMS_Ln9.ne0ARCTICGRISne30x8_ne0ARCTICGRISne30x8_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam6LndTuningMode_1979Start
/glade/campaign/cgd/tss/ctsm_baselines/ctsm_sci-ctsm5.2.007/SMS_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam6LndTuningMode_1979Start

can you compare your CAM tests to those and tell me what's different in the CAM tests? I'll then replicate this in CTSM and open an issue to fix in CTSM.

@brian-eaton
Copy link
Collaborator

Thanks for looking at this @ekluzek.
My current test failures don't produce a clm_inparm namelist because of the build-namelist failure. But if I look back to previous successful runs on the ne0ARCTICne30x4 grid I see that use_init_interp = .true. is set in those runs.

I'm not sure what to compare in the runs you point out. My run failures are:

  SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
  SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:

both in directory /glade/derecho/scratch/eaton/aux_cam_20240612070616
maybe you could look there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc tag issue or PR candidate for upcoming misc tag
Projects
Status: Done
Development

No branches or pull requests

6 participants