Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up run_tower.py #2671

Open
5 tasks
TeaganKing opened this issue Jul 30, 2024 · 2 comments
Open
5 tasks

Clean up run_tower.py #2671

TeaganKing opened this issue Jul 30, 2024 · 2 comments
Labels
enhancement new capability or improved behavior of existing capability

Comments

@TeaganKing
Copy link
Contributor

TeaganKing commented Jul 30, 2024

In a discussion with @danicalombardozzi , Sam, and Gordon, we talked about a few items related to run_neon.py that would ideally be changed for clarification purposes. Rachel has run into a few confusing pieces of information while working with Danica, so we might want to keep her in the loop and/or tag her if she makes a GitHub account.

Here is our ideal tower refactoring wish list (for after PLUMBER2 comes in):

  • Clarify the use of base case. This is confusing for users because we use the same base case in multiple places.
  • Start date is confusingly set to year 18 in env_run.xml based on NEON usually starting in 2018 and ad/postad starting on 0018 and 1018 respectively. This doesn't necessarily cause issues, but is confusing.
  • AD spin up is set up with --setup_only but then requires ./case.setup which could be misleading
  • There is a duplication of code with user_nl_clm and changes in the first bit of the namelist are overwritten by the second instance of the namelist
  • Use RUN_REFTOD instead of START_TOD in PLUMBER2 usermods & update buildnml tod accordingly
@TeaganKing TeaganKing added the enhancement new capability or improved behavior of existing capability label Jul 30, 2024
@danicalombardozzi
Copy link
Contributor

danicalombardozzi commented Aug 7, 2024

Here is another issue to explore. Setting up a transient simulation (for MOAB, haven't tested other sites) using the --experiment option set incorrect values for these variables:
entry id="RUN_STARTDATE" value="2000-01-01"
entry id="STOP_N" value="5"

@TeaganKing
Copy link
Contributor Author

Thanks Danica.

I'll also add the BGC/SP case flag as an additional feature to address on this issue (see discussion in #2406).

@TeaganKing TeaganKing changed the title Clean up run_neon.py Clean up run_tower.py Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
No open projects
Development

No branches or pull requests

2 participants