-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to shr_drydep_mod module #1843
Conversation
@fvitt thanks so much for putting this together, and so quickly! That's really helpful. We need to figure out when and how to bring this in, but having a PR makes it possible to do that. I did a quick look at your changes and they seem straightforward. But, I might get back to you when we take a closer look. |
@fvitt it looks like one change is to assume that drydep is going to be calculated inside of CTSM, rather than the option to switch it between CAM or CTSM or a table. So this removes drydep_method and lnd_drydep variables. I just wanted to make sure I understood that change. |
Yes, that is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I like the idea that this simplifies the code to make it always assume that dry-dep is coming from CTSM.
@fvitt just FYI @adrifoster is going to take on bringing this PR to main-dev CTSM. It's now scheduled as the next tag. She is going to add another externals update and do more testing with it and then bring it in as the next CTSM tag. After that she has the ozone work that builds on top of this. |
Thanks @fvitt for doing this PR so quickly!! |
@fvitt @adrifoster ran into some unexpected fails as follows. Can you look into this and provide a fix for it?
From cesm log of one of them:
|
modified: bld/CLMBuildNamelist.pm modified: bld/namelist_files/namelist_defaults_drydep.xml modified: bld/namelist_files/namelist_definition_drv_flds.xml modified: src/main/controlMod.F90
@ekluzek |
@fvitt yes thanks for sending fixes in. @adrifoster will try it out and let us know if this resolves everything. Yes, you are correct that check in controlMod wasn't correctly constructed, and @adrifoster will just remove it completely. |
From #270, we are doing testing to bring CTSM externals up to date now:
Cheyenne aux_clm: /glade/scratch/afoster/tests_0831-145952c - all DIFF fails and expected RUN fails Izumi aux_xlm: /scratch/cluster/afoster/tests_0831-144810iz - all DIFF fails, RUN fails that will get fixed in a subsequent externals update:
Cheyenne aux_clm: **/glade/scratch/afoster/tests_0831-175106ch ** - mostly NLCOMP fails, DIFF fails for single-point/NEON (as expected), other DIFF fails that are expected based on a cdeps NLDAS update, CREATE_NEWCASE fail that is now an existing issue:
Izumi aux_xlm: /scratch/cluster/afoster/tests_0831-175502iz - mostly NLCOMP fails, DIFF fails for single point as expected
Cheyenne aux_clm: **/glade/scratch/afoster/tests_0906-141452ch ** - all NLCOMP and FIELDLIST diffs Izumi aux_clm: /scratch/cluster/afoster/tests_0906-141620iz - all NLCOMP and FIELDLIST diffs @billsacks and @ekluzek anything else that needs to get tested? |
Great @adrifoster ! Thank you for doing all this testing! This seems good to me at this point. |
Description of changes
Use
shr_drydep_mod
rather than theseq_drydep_mod
module (which is merely a wrapper to shr_drydep_mod).Specific notes
Namelist option
drydep_method
is removed. The other dry deposition options were obsolete and were removed from the code base. The only method available now is the "land" method. We are dependent on the land model to provide deposition velocities of chemical constituents over land in all configurations.Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #): #1822
Are answers expected to change (and if so in what way)? No
Expect bit-for-bit unchanged
Any User Interface Changes (namelist or namelist defaults changes)?
Namelist option
drydep_method
is removedTesting performed, if any:
Only tested a few F compsets with chemistry
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).