Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq_drydep_mod should be replaced by shr_drydep_mod #1822

Closed
fvitt opened this issue Aug 3, 2022 · 7 comments
Closed

seq_drydep_mod should be replaced by shr_drydep_mod #1822

fvitt opened this issue Aug 3, 2022 · 7 comments
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations

Comments

@fvitt
Copy link
Contributor

fvitt commented Aug 3, 2022

The use of seq_drydep_mod in source code should be replaced by shr_drydep_mod. As of CMEPS tag cmeps0.13.70 and cpl7 tag cpl7.0.14, seq_drydep_mod.F90 is merely a wrapper to shr_drydep_mod.F90 and is subject to be removed in a future CMEPS tag when CTSM is ready.

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 4, 2022
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 4, 2022

@fvitt does this change answers at all or are answers identical with either version?

@fvitt
Copy link
Contributor Author

fvitt commented Aug 4, 2022

This change does not change answers

@billsacks billsacks added tag: simple bfb code health improving internal code structure to make easier to maintain (sustainability) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations labels Aug 4, 2022
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 4, 2022
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 1, 2022

@billsacks and @adrifoster this is the thing that gets in the way of the Ozone tag.

@billsacks
Copy link
Member

I think there's more than just that: It looks like we also need to stop setting drydep_method in drv_flds_in, possibly replacing it with some new variable. @fvitt can you please give us some guidance on what we need in CTSM to be compatible with ESCOMP/CMEPS#303, similar to whatever was done in ESCOMP/CAM#602?

@fvitt
Copy link
Contributor Author

fvitt commented Sep 1, 2022

@billsacks and @adrifoster this is the thing that gets in the way of the Ozone tag.

What is the "Ozone tag"?

@fvitt
Copy link
Contributor Author

fvitt commented Sep 1, 2022

I think there's more than just that: It looks like we also need to stop setting drydep_method in drv_flds_in, possibly replacing it with some new variable. @fvitt can you please give us some guidance on what we need in CTSM to be compatible with ESCOMP/CMEPS#303, similar to whatever was done in ESCOMP/CAM#602?

Would it help if I prepare a PR to ESCOMP/CTSM for this?

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 1, 2022

@fvitt that would be great if you could make a PR for this!

The "Ozone tag" by the way is some work that @adrifoster is bringing in that passes some Ozone fields from ATM to LND. There are PR's in both CMEPS and CDEPS for it. I think the CMEPS one is cmeps0.13.71 just after your CMEPS changes came in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
Development

No branches or pull requests

4 participants