index node upgrade aborts in setup_search

[alaniwi]

add_shard returns 1 if you answer no to this question:

            echo " A replica shard entry for ${config_type%:*} is already present!"
            read -p " Are you sure you wish to add a NEW replica index for ${config_type%:*}? [Y/n] " answer
            [ -z "${answer}" ] || [ "$(tr A-Z a-z <<< ${answer})" = "n" ] && return 1

This aborts the upgrade inside the calling code:

        add_shard ${config_type}
        [ $? != 0 ] && echo " ERROR: Could not fully install solr :-( " && checked_done 1

It is possible to work around it in esg-node by commenting out the high-level call to setup_subsystem search, and then the installer will run to completion. (Attempts to work around inside esg-search itself fail because it is overwritten with a fresh copy.) If solr is updated separately outside of the esg-node update procedure, does this cover everything of importance?

[alaniwi]

This was during test update from 2.6.1 to 2.7.1

[sashakames]

It is probably harmless to replace the solr installation with one of the same version. If you comment out subsystem search, you would miss the esg-search module upgrade, though that may not be needed or would be done manually.