-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 4 dataset metadata distributions #81
Conversation
Also added metadata diagram.
Main changes for this PR can be reviewed as rendered (with the diagram): https://github.com/ESIPFed/science-on-schema.org/blob/feature_4_dataset_metadata_distributions/guides/Dataset.md#metadata The ADR for this PR from @ashepherd is: https://github.com/ESIPFed/science-on-schema.org/blob/feature_4_dataset_metadata_distributions/decisions/4-dataset-metadata-distributions.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the schema.org "Values expected to be one of these types" for subjectOf are CreativeWork or Event, but the structured data testing tool doesn't throw an error for @type download, so its not breaking.
ADR looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest revising to acknowledge equivalence of subjectOf
and about
. It seems unnecessarily restrictive to emphasize the subjectOf
approach, and may impact adoption of the recommendation. For example, ro-crate suggests the about
approach.
Modifications of the Dataset.md guide for feature #4 on metadata distribution info. See the issue #4 for details of the design and discussion.