Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 4 dataset metadata distributions #81

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

mbjones
Copy link
Collaborator

@mbjones mbjones commented Jan 22, 2020

Modifications of the Dataset.md guide for feature #4 on metadata distribution info. See the issue #4 for details of the design and discussion.

@mbjones mbjones added proposed decision Update Documentation updates to the guidance docs labels Jan 22, 2020
@mbjones mbjones added this to the v1.1 milestone Jan 22, 2020
Copy link
Contributor

@smrgeoinfo smrgeoinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the schema.org "Values expected to be one of these types" for subjectOf are CreativeWork or Event, but the structured data testing tool doesn't throw an error for @type download, so its not breaking.

ADR looks good to me

Copy link
Collaborator

@datadavev datadavev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest revising to acknowledge equivalence of subjectOf and about. It seems unnecessarily restrictive to emphasize the subjectOf approach, and may impact adoption of the recommendation. For example, ro-crate suggests the about approach.

guides/Dataset.md Show resolved Hide resolved
@mbjones mbjones merged commit 1411ab6 into develop Feb 28, 2020
@ashepherd ashepherd deleted the feature_4_dataset_metadata_distributions branch May 15, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposed decision Update Documentation updates to the guidance docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants