-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin lower bound for iris to 3.0.2 #1206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 188 188
Lines 9133 9133
=======================================
Hits 7810 7810
Misses 1323 1323 Continue to review full report at Codecov.
|
I definitely like this! Would like to see it in our own bugfix release. Do you think you could finish this up asap? |
the only two things that are still needed for it to be shipshape are merge #1197 that fixes the tests for Python 3.7-9 (and then I can remove the Github Actions test branch) and me tidying up the boxes above, all else should be fine I think |
Thanks, V! The merge is done, now you are on box duty ;) |
Boss! Let me take care of it now 👍 |
Everything except for the conda-build worked, so once the checklist is done, I'll do the final review and we can get this in. |
done, man 🍺 |
cheers K-man 🍻 |
* pin iris to latest * pin iris to latest * pin iris to latest * test in GA * remove GA test branch
Description
A bunch of bugfixes and improvements have been added in the 3.0.2 release of iris, including a fix to a nasty bounds behavior, see last comment on the issue - this is not make or break but it's good to make sure we don't pick up an older (3.0.1 actually) version. I suggest we have this in time for the imminent bugfix release 2.3.1 😁
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.