Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin lower bound for iris to 3.0.2 #1206

Merged
merged 6 commits into from
Jul 7, 2021
Merged

Pin lower bound for iris to 3.0.2 #1206

merged 6 commits into from
Jul 7, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 1, 2021

Description

A bunch of bugfixes and improvements have been added in the 3.0.2 release of iris, including a fix to a nasty bounds behavior, see last comment on the issue - this is not make or break but it's good to make sure we don't pick up an older (3.0.1 actually) version. I suggest we have this in time for the imminent bugfix release 2.3.1 😁

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@valeriupredoi valeriupredoi added installation Installation problem iris Related to the Iris package deployment labels Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1206 (e61b8a7) into main (0a428cb) will not change coverage.
The diff coverage is n/a.

❗ Current head e61b8a7 differs from pull request most recent head f51b8ed. Consider uploading reports for the commit f51b8ed to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files         188      188           
  Lines        9133     9133           
=======================================
  Hits         7810     7810           
  Misses       1323     1323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a428cb...f51b8ed. Read the comment docs.

@zklaus
Copy link

zklaus commented Jul 5, 2021

I definitely like this! Would like to see it in our own bugfix release. Do you think you could finish this up asap?

@zklaus zklaus added this to the v2.3.1 milestone Jul 5, 2021
@valeriupredoi
Copy link
Contributor Author

the only two things that are still needed for it to be shipshape are merge #1197 that fixes the tests for Python 3.7-9 (and then I can remove the Github Actions test branch) and me tidying up the boxes above, all else should be fine I think

@zklaus
Copy link

zklaus commented Jul 7, 2021

Thanks, V! The merge is done, now you are on box duty ;)

@valeriupredoi
Copy link
Contributor Author

Boss! Let me take care of it now 👍

@zklaus
Copy link

zklaus commented Jul 7, 2021

Everything except for the conda-build worked, so once the checklist is done, I'll do the final review and we can get this in.

@valeriupredoi
Copy link
Contributor Author

done, man 🍺

@zklaus zklaus merged commit df529d5 into main Jul 7, 2021
@zklaus zklaus deleted the bump_iris_to_latest branch July 7, 2021 13:42
@valeriupredoi
Copy link
Contributor Author

cheers K-man 🍻

zklaus pushed a commit that referenced this pull request Jul 21, 2021
* pin iris to latest

* pin iris to latest

* pin iris to latest

* test in GA

* remove GA test branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment installation Installation problem iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants