-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped Python 3.7 #1530
Dropped Python 3.7 #1530
Conversation
@runGAtests |
Codecov Report
@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 197 197
Lines 10568 10568
=======================================
Hits 9592 9592
Misses 976 976 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to drop the gramps Python, cheers, Manu!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yepp, that's the way to go.
Cheers guys! I will wait for a couple of hours (say until 4pm CET) if anyone from the @ESMValGroup/esmvaltool-coreteam has any objections, then will proceed with the merge 👍 |
nice of you 😃 |
GitHub Actions ran successful (apart from the OSX 3.7 of course): https://github.com/ESMValGroup/ESMValCore/actions/runs/1962822315 I noticed that every comment in this PR triggers a GitHub action (e.g., https://github.com/ESMValGroup/ESMValCore/actions/runs/1962915977), is this on purpose? |
if you are bit confused why there is a 3.7 OSX run here that is because the dumb GA bot is running the workflow that is on |
That's what I thought 😄 |
aagh! I know what those are - not just codecov - but any comment - it tries to initiate the GA test but because there is no key string (am not gonna write it here coz I'd invoke the test) in the comment it stops, I need to figure out how to not have the initial phase of the test triggered - Github Actions documentation is blithering terrible |
Ahh, and it does that regardless if the keyword was mentioned in that PR or not (see #1308)... |
seems like I have created a thing more verbose than my mum 🤣 Hang on lemme see what I can do about that |
Description
See discussion here: ESMValGroup/ESMValTool#2584. On OSX, Python 3.7 is no longer supported by conda-forge.
Closes #1528
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: