Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped Python 3.7 #1530

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Dropped Python 3.7 #1530

merged 1 commit into from
Mar 10, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 10, 2022

Description

See discussion here: ESMValGroup/ESMValTool#2584. On OSX, Python 3.7 is no longer supported by conda-forge.

Closes #1528


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma
Copy link
Contributor Author

@runGAtests

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1530 (89d1501) into main (faea19b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         197      197           
  Lines       10568    10568           
=======================================
  Hits         9592     9592           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faea19b...89d1501. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to drop the gramps Python, cheers, Manu!

Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp, that's the way to go.

@schlunma
Copy link
Contributor Author

Cheers guys!

I will wait for a couple of hours (say until 4pm CET) if anyone from the @ESMValGroup/esmvaltool-coreteam has any objections, then will proceed with the merge 👍

@valeriupredoi
Copy link
Contributor

Cheers guys!

I will wait for a couple of hours (say until 4pm CET) if anyone from the @ESMValGroup/esmvaltool-coreteam has any objections, then will proceed with the merge +1

nice of you 😃

@schlunma
Copy link
Contributor Author

GitHub Actions ran successful (apart from the OSX 3.7 of course): https://github.com/ESMValGroup/ESMValCore/actions/runs/1962822315

I noticed that every comment in this PR triggers a GitHub action (e.g., https://github.com/ESMValGroup/ESMValCore/actions/runs/1962915977), is this on purpose?

@valeriupredoi
Copy link
Contributor

if you are bit confused why there is a 3.7 OSX run here that is because the dumb GA bot is running the workflow that is on main rather the one in this PR. I am very confused as to what the crappe are those autofailed tests triggered by codecov tho

@schlunma
Copy link
Contributor Author

if you are bit confused why there is a 3.7 OSX run here that is because the dumb GA bot is running the workflow that is on main rather the one in this PR.

That's what I thought 😄

@schlunma
Copy link
Contributor Author

I am very confused as to what the crappe are those autofailed tests triggered by codecov tho

They are not triggered by codecov, but by our comments:

grafik

@valeriupredoi
Copy link
Contributor

aagh! I know what those are - not just codecov - but any comment - it tries to initiate the GA test but because there is no key string (am not gonna write it here coz I'd invoke the test) in the comment it stops, I need to figure out how to not have the initial phase of the test triggered - Github Actions documentation is blithering terrible

@schlunma
Copy link
Contributor Author

Ahh, and it does that regardless if the keyword was mentioned in that PR or not (see #1308)...

@valeriupredoi
Copy link
Contributor

seems like I have created a thing more verbose than my mum 🤣 Hang on lemme see what I can do about that

@schlunma schlunma merged commit 86b0984 into main Mar 10, 2022
@schlunma schlunma deleted the drop_py37 branch March 10, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX Test and Monitor Test GA tests are failing for all Pythons
3 participants