Do not realise coordinates in check.py
#1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1912 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 234 234
Lines 12057 12057
=======================================
Hits 11098 11098
Misses 959 959
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
valeriupredoi
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
what a cute little, yet very useful PR, cheers @sloosvel 🍺 Do you want to tidy up the PR description boxes, please? Then tut-tut about the PR so it can be merged 👍
sloosvel
added
enhancement
|
Sure, done! |
|
@ESMValGroup/technical-lead-development-team can one of you peeps have a glance at this, and merge, please? 🍺 |
|
Thanks!! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
check.pyso that it callscoord.core_points()andcoord.core_bounds()when checking the coordinates , in order to not realise 2D latitudes and longitudes.Closes #1906
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: