-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul concatenation and allow for correct concatenation of multiple overlapping datasets #615
Conversation
@bjlittle such an implementation would be nice to have in iris, this can easily be ported if you guys would be OK with it 🍺 |
@bouweandela @jvegasbsc cen we have a look at this pls, I suspect it's gonna be quite useful (@mwjury has already tested for his two used cases that were not working previously) 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, but I think the implementation could still be simplified a bit. Could you have a look?
cheers @bouweandela you are correct - I have streamlined it now, have a looksee 🍺 |
@valeriupredoi - I found that this was a problem with the NorESM2-LM dataset as well. I think the same fix will work. Happy to try out once this branch is merged with the master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, could you please have a look at the comments?
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
all done, mi amigo @bouweandela 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now! Just a tiny remark about the error message.
@mattiarighi Could you please test?
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
cheers @bouweandela - no need to test, @mwjury tested this in the issue, and meself included 🍺 |
Sorry, I forgot to ask about Codacy, could you have a look? |
yeah Codacy can go for a walk 😁 |
Before you start, please read CONTRIBUTING.md.
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #574
Summary
_io.py
)New Features
[A, B, C, D...]
with any sort of overlap in time between the cubesiris
's faulty automatic concatenation of eg[A, B, D]
with a massive gap between B and D and inability of previous implementation to plug the gap with C[A, B, D, C...]
and B and D don't have an overlap but C or later cubes overlap, it will still workTagline