Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figures for IPCC AR6 WG1 Chapter 3 (Atmosphere) #2533

Merged
merged 49 commits into from Aug 19, 2022

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Feb 15, 2022

Description

This contains the code for Fig. 3.3, 3.4, 3.5, 3,13 and 3.15 of the IPCC AR6 WG1 report.

Figure 3.3 a,b,c,d: Surface Air Temperature - Model Bias
Figure 3.4: Anomaly Of Near-Surface Air Temperature
Figure 3.5: Temporal Variability Of Near-Surface Air Temperature
Figure 3.13 a,b,c,d: Precipitation - Model Bias
Figure 3.15: Precipitation Anomaly

Documentation preview: https://esmvaltool--2533.org.readthedocs.build/en/2533/recipes/recipe_ipccwg1ar6ch3.html


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

@LisaBock LisaBock added the IPCC label Feb 15, 2022
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @LisaBock! The recipe runs fine with v2.6, produces the right plots, provenance is added for all produced files and the documentation looks good to me. I left a few minor comments regarding documentation.

I am no expert of the NCL diagnostics and I can only say that the added ones look good to me. I see that you have edited two shared diagnostic scripts, diag_scripts/shared/plot/xy_line.ncl and diag_scripts/shared/statistics.ncl which seem to be both used in other diagnostics and thus recipes. Could you please comment if the modifications to these 2 diagnostics would have consequences for other recipes? Should we run other recipes to check if some results of other recipes would be impacted by the changes introduced in this PR?

@remi-kazeroni
Copy link
Contributor

remi-kazeroni commented Jul 28, 2022

  • I noticed that the three files None_data_citation_info.txt, None_citation.bibtex, None_provenance.xml are written to the root of output_dir. That looks a bit strange and might need to be checked.

This is probably due to an issue in esmvaltool/diag_scripts/ipcc_ar5/ch12_calc_IAV_for_stippandhatch.ncl which is used in several recipes rather than an issue introduced in this PR. I had seen this when running recipe_collins13ipcc for releases. I'll try to investigate that and open a separate issue to discuss that.
Edit: see #2756

@LisaBock
Copy link
Contributor Author

@axel-lauer and @remi-kazeroni Thanks for your reviews!

Hopefully I adressed all you comments. Maybe you could have a second look...

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this once more. All my previous comments have been addressed. Thanks @LisaBock ! This is ready for being merged.

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @LisaBock! This PR is good to be merged. Great to have some IPCC AR6 diagnostics in the Tool 👍

@remi-kazeroni remi-kazeroni added this to the v2.7.0 milestone Aug 19, 2022
@axel-lauer axel-lauer merged commit 79a35dd into main Aug 19, 2022
@axel-lauer axel-lauer deleted the ar6_chapter_3_atmosphere branch August 19, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants